Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Integration Tests] Clear opcode cache after config change #4302

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

LukasReschke
Copy link
Member

Let's see…

@LukasReschke LukasReschke added the 1. to develop Accepted and waiting to be taken care of label Apr 11, 2017
@mention-bot
Copy link

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @schiessle and @ChristophWurst to be potential reviewers.

@ChristophWurst
Copy link
Member

All checks have passed

soooo… what did you debug/test here? I'm just curious …

@LukasReschke
Copy link
Member Author

13:13:12 R<rullzer> mmm I rebased https://github.com/nextcloud/server/pull/3905 on master... but your fancy new test fails... https://drone.nextcloud.com/nextcloud/server/6992/7 ... known?

😃

@LukasReschke
Copy link
Member Author

Also failing on #4304 … mhm…

@nickvergessen
Copy link
Member

If all failes, use the testing apps api

@LukasReschke
Copy link
Member Author

If all failes, use the testing apps api

Yeah. I suspect the OPCode cache to be to blame… Let me add a small PHP file to the testing app that cleans the OPCode. For testing purposes only of course :-)

@LukasReschke LukasReschke force-pushed the test-integration-test branch 2 times, most recently from 5799116 to 925e05d Compare April 11, 2017 15:48
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke force-pushed the test-integration-test branch from 925e05d to 4cf6148 Compare April 11, 2017 16:58
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@45a6e37). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4302   +/-   ##
=========================================
  Coverage          ?   54.14%           
  Complexity        ?    21395           
=========================================
  Files             ?     1327           
  Lines             ?    81789           
  Branches          ?     1304           
=========================================
  Hits              ?    44287           
  Misses            ?    37502           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
version.php 0% <0%> (ø) 0 <0> (?)
apps/testing/clean_opcode_cache.php 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a6e37...4cf6148. Read the comment docs.

@LukasReschke LukasReschke changed the title [CI] Debug integration test [Integration Tests] Clear opcode cache after config change Apr 11, 2017
@LukasReschke
Copy link
Member Author

LukasReschke commented Apr 11, 2017

Ok. This seems to work now 🚀

@LukasReschke LukasReschke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Apr 11, 2017
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Apr 11, 2017
@rullzer rullzer merged commit 8175ac6 into master Apr 11, 2017
@rullzer rullzer deleted the test-integration-test branch April 11, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants