Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites integration tests for shared files #4306

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Favorites integration tests for shared files #4306

merged 1 commit into from
Apr 12, 2017

Conversation

MorrisJobke
Copy link
Member

@rullzer @schiessle It returns 403 Forbidden when a (favourited) files is moved from a shared folder to the root. Is this intended? I think it's a bug :/

@rullzer rullzer self-assigned this Apr 11, 2017
@rullzer
Copy link
Member

rullzer commented Apr 11, 2017

I'll dive into this...

@MorrisJobke
Copy link
Member Author

This should be fixed by #4329 I guess

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member Author

This should be fixed by #4329 I guess

I rebased. Let's see if it works fine.

@rullzer
Copy link
Member

rullzer commented Apr 12, 2017

Seems so!

@codecov-io
Copy link

Codecov Report

Merging #4306 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4306      +/-   ##
============================================
- Coverage     54.03%   54.03%   -0.01%     
  Complexity    21418    21418              
============================================
  Files          1321     1321              
  Lines         81698    81698              
  Branches       1305     1305              
============================================
- Hits          44149    44147       -2     
- Misses        37549    37551       +2
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.39% <0%> (-0.25%) 133% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31024b7...4cf4d2f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants