Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for trashbin #3893

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Add integration test for trashbin #3893

merged 2 commits into from
Mar 17, 2017

Conversation

MorrisJobke
Copy link
Member

Vincent Petry and others added 2 commits March 16, 2017 23:53
@MorrisJobke
Add integration test for trashbin
659006c 
Add test for basic deletion.
Add test when deleting from shared folder as recipient.
Add test to check that metadata stays when moving out of shared folder
as recipient.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Add drone.yml config
5d29e84 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 17, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @LukasReschke and @rullzer to be potential reviewers.

nickvergessen
nickvergessen approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes, fine by me. However I still think the functional tests need some structure one day.

build/integration/features/bootstrap/BasicStructure.php
@@ -35,6 +35,7 @@
trait BasicStructure {

use Auth;
use Trashbin;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

rullzer
rullzer approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@rullzer rullzer merged commit 3f331e0 into master Mar 17, 2017
@rullzer rullzer deleted the downstream-27069 branch March 17, 2017 09:10
@MorrisJobke
Copy link
Member Author

Test passes, fine by me. However I still think the functional tests need some structure one day.

No they don't :/

@MorrisJobke MorrisJobke mentioned this pull request Mar 17, 2017
Merged
@MorrisJobke
Copy link
Member Author

Reverted because the unit tests fail.

@MorrisJobke MorrisJobke mentioned this pull request Mar 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: trashbin
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @mention-bot @rullzer @nickvergessen