Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v1.4.0 rc july #4489

Merged
merged 30 commits into from
Sep 21, 2022
Merged

Update v1.4.0 rc july #4489

merged 30 commits into from
Sep 21, 2022

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Sep 20, 2022

Description of the reasoning behind the pull request

  • merge

Proposed Changes

  • merge

Testing procedure

  • standard test

schimih and others added 29 commits August 12, 2022 10:10
change label name to ignore-for-release-notes
Create static storer for meta if snapshots are disabled
async callback arguments inconsitency fix
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	integrationTests/multiShard/smartContract/polynetworkbridge/bridge_test.go
#	node/nodeRunner.go
#	process/smartContract/process.go
#	process/smartContract/process_test.go
#	storage/factory/pruningStorerFactory.go
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Base: 73.42% // Head: 73.42% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (36680d1) compared to base (ceabff3).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.4.0    #4489      +/-   ##
=============================================
- Coverage      73.42%   73.42%   -0.01%     
=============================================
  Files            655      655              
  Lines          85369    85376       +7     
=============================================
+ Hits           62682    62684       +2     
- Misses         17842    17845       +3     
- Partials        4845     4847       +2     
Impacted Files Coverage Δ
node/nodeRunner.go 0.00% <0.00%> (ø)
trie/trieStorageManagerInEpoch.go 80.55% <50.00%> (ø)
common/enablers/enableEpochsHandler.go 73.84% <100.00%> (+0.20%) ⬆️
common/enablers/epochFlags.go 92.30% <100.00%> (+0.08%) ⬆️
process/smartContract/process.go 65.94% <100.00%> (+0.04%) ⬆️
common/pidQueue.go 93.33% <0.00%> (-3.34%) ⬇️
statusHandler/statusMetricsProvider.go 97.09% <0.00%> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@iulianpascalau iulianpascalau merged commit 62f2d9e into rc/v1.4.0 Sep 21, 2022
@iulianpascalau iulianpascalau deleted the update-v1.4.0-rc-july branch September 21, 2022 11:05
@schimih schimih added the ignore-for-release-notes Do not include item in release notes label Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants