Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change label name to ignore-for-release-notes #4369

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

schimih
Copy link
Contributor

@schimih schimih commented Aug 12, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • previously named ignore-for-release label was changed to ignore-for-release-notes to remove any confusion with regards to the scope of the PR

Proposed Changes

  • change the name of the label

Testing procedure

  • automatically generate a release note and check if PR's are distributed to proper chapter.

@schimih schimih added the ignore-for-release-notes Do not include item in release notes label Aug 12, 2022
@schimih schimih self-assigned this Aug 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4369 (5c2a752) into master (3a29c56) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4369      +/-   ##
==========================================
- Coverage   70.92%   70.92%   -0.01%     
==========================================
  Files         618      618              
  Lines       82508    82508              
==========================================
- Hits        58520    58518       -2     
- Misses      19762    19763       +1     
- Partials     4226     4227       +1     
Impacted Files Coverage Δ
storage/txcache/txListBySenderMap.go 97.50% <0.00%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schimih schimih merged commit 8e402fa into master Aug 12, 2022
@schimih schimih deleted the update-release-yml branch August 12, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants