Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade indexer #4469

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Upgrade indexer #4469

merged 2 commits into from
Sep 16, 2022

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Sep 15, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

Proposed Changes

  • The new indexer version will extend the block structure with extra fields about the execution of a miniblock (the block structure will contain the indices of the first and last transaction processed from a specific miniblock)

Testing procedure

  • Run a system test with a lot of transactions.
  • Find a block with partial executed miniblocks.
  • Check if the specific block indexed in the ES contains information about the execution of the miniblock.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rc/2022-july@ceeb79f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             rc/2022-july    #4469   +/-   ##
===============================================
  Coverage                ?   73.93%           
===============================================
  Files                   ?      679           
  Lines                   ?    86965           
  Branches                ?        0           
===============================================
  Hits                    ?    64299           
  Misses                  ?    17864           
  Partials                ?     4802           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@miiu96 miiu96 merged commit 7981f9e into rc/2022-july Sep 16, 2022
@miiu96 miiu96 deleted the indexer-partial-executed-mb-data branch September 16, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants