Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async callback arguments inconsitency fix #4470

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

sasurobert
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

Inconsistency of arguments when creating asynchronous callback SCR from an output transfer

Proposed Changes

Added missing argument. Only after activation of special flag (backward compatibility issues).

Testing procedure

Deploy a contract, issue a token from that contract through asnycCall, check one of the resulting SCRs which is with type AsyncchronousCallback. It should start with "@00" after activation. Before activation this one is missing.

@iulianpascalau iulianpascalau self-requested a review September 15, 2022 13:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 73.93% // Head: 73.93% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (7a0610c) compared to base (72b3676).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           rc/2022-july    #4470      +/-   ##
================================================
- Coverage         73.93%   73.93%   -0.01%     
================================================
  Files               679      679              
  Lines             86963    86965       +2     
================================================
- Hits              64299    64297       -2     
- Misses            17862    17864       +2     
- Partials           4802     4804       +2     
Impacted Files Coverage Δ
process/smartContract/process.go 68.79% <100.00%> (+0.03%) ⬆️
storage/txcache/txListBySenderMap.go 97.50% <0.00%> (-2.50%) ⬇️
p2p/libp2p/netMessenger.go 80.02% <0.00%> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@iulianpascalau iulianpascalau merged commit 5aed6c6 into rc/2022-july Sep 16, 2022
@iulianpascalau iulianpascalau deleted the callBack-inconsistency branch September 16, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants