Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc into feat multisigner 12.09.2022 #4458

Merged

Conversation

sstanculeanu
Copy link
Collaborator

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

Proposed Changes

Testing procedure

BeniaminDrasovean and others added 30 commits August 8, 2022 13:59
…-if-necessary

# Conflicts:
#	.github/workflows/build_and_test.yml
#	.github/workflows/code-coverage.yml
#	.github/workflows/create_release.yml
- hb v1 monitor no longer returns data after disable epoch
BeniaminDrasovean and others added 23 commits September 7, 2022 12:20
# Conflicts:
#	cmd/node/flags.go
#	config/contextFlagsConfig.go
#	factory/stateComponents.go
#	heartbeat/process/monitor.go
#	heartbeat/process/monitor_test.go
#	node/nodeRunner.go
…elopment/github.com/urfave/cli-1.22.10

Bump github.com/urfave/cli from 1.22.9 to 1.22.10
…_auth_requests

Fix missing epoch on peer authentication messages requests
….0_11.09.2022

Merge rc july into rc 1.4.0 11.09.2022
…at_multisigner_12.09.2022

# Conflicts:
#	cmd/node/config/config.toml
#	config/config.go
#	factory/heartbeatV2Components.go
#	factory/heartbeatV2Components_test.go
#	heartbeat/errors.go
#	heartbeat/sender/heartbeatSender.go
#	heartbeat/sender/peerAuthenticationSender.go
#	heartbeat/sender/sender.go
#	heartbeat/sender/sender_test.go
#	integrationTests/testHeartbeatNode.go
#	integrationTests/testProcessorNode.go
#	testscommon/generalConfig.go
@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Sep 12, 2022
@sstanculeanu sstanculeanu self-assigned this Sep 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4458 (43dadc2) into feat/multisigner (278fe0c) will increase coverage by 0.00%.
The diff coverage is 80.41%.

@@                Coverage Diff                @@
##           feat/multisigner    #4458   +/-   ##
=================================================
  Coverage             73.91%   73.91%           
=================================================
  Files                   694      697    +3     
  Lines                 88638    88727   +89     
=================================================
+ Hits                  65515    65585   +70     
- Misses                18189    18206   +17     
- Partials               4934     4936    +2     
Impacted Files Coverage Δ
cmd/termui/presenter/chainInfoGetters.go 82.22% <0.00%> (-1.87%) ⬇️
cmd/termui/presenter/instanceInfoGetters.go 80.48% <0.00%> (-4.13%) ⬇️
factory/consensusComponents.go 0.00% <0.00%> (ø)
node/nodeRunner.go 0.00% <0.00%> (ø)
storage/factory/pruningStorerFactory.go 0.00% <0.00%> (ø)
factory/processComponents.go 53.19% <48.64%> (-0.04%) ⬇️
heartbeat/sender/heartbeatSender.go 89.55% <68.75%> (-6.53%) ⬇️
...t/processor/peerAuthenticationRequestsProcessor.go 94.87% <75.00%> (-1.98%) ⬇️
factory/heartbeatV2Components.go 76.00% <80.95%> (+0.81%) ⬆️
storage/pruning/pruningStorer.go 73.58% <86.11%> (+0.17%) ⬆️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sstanculeanu sstanculeanu merged commit 8475ec8 into feat/multisigner Sep 12, 2022
@sstanculeanu sstanculeanu deleted the merge_rc_into_feat_multisigner_12.09.2022 branch September 12, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants