Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing epoch on peer authentication messages requests #4450

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

sstanculeanu
Copy link
Collaborator

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • epoch is missing from RequestData object, while requesting peer authentication messages, leading to always requesting from epoch 0, which sometimes therefore leads to querying nodes from full history list, which may be empty

Proposed Changes

  • add epoch on RequestData object

Testing procedure

  • standard system test, looking for peer list is empty or errors during the sending, topic: peerAuthentication not to be present

@codecov-commenter
Copy link

Codecov Report

Merging #4450 (f92e704) into rc/2022-july (662828d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           rc/2022-july    #4450      +/-   ##
================================================
- Coverage         73.93%   73.93%   -0.01%     
================================================
  Files               679      679              
  Lines             86960    86965       +5     
================================================
+ Hits              64292    64295       +3     
- Misses            17865    17866       +1     
- Partials           4803     4804       +1     
Impacted Files Coverage Δ
dataRetriever/requestHandlers/requestHandler.go 75.10% <100.00%> (+0.15%) ⬆️
...aRetriever/resolvers/peerAuthenticationResolver.go 94.82% <100.00%> (+0.09%) ⬆️
storage/txcache/txListBySenderMap.go 97.50% <0.00%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 131e878 into rc/2022-july Sep 10, 2022
@gabi-vuls gabi-vuls deleted the fix_missing_epoch_on_peer_auth_requests branch September 10, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants