-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/heartbeat fixes #4441
Merged
Merged
Feat/heartbeat fixes #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hb v1 monitor no longer returns data after disable epoch
…nnections' metrics from monitor
Fix heartbeat v2 metrics update
…rs. metricsUpdater benefits from this, it better updates the metric
Fix hb v2 metrics issues + hb status returned
Further hb v2 fixes
Codecov Report
@@ Coverage Diff @@
## rc/2022-july #4441 +/- ##
================================================
- Coverage 73.93% 73.93% -0.01%
================================================
Files 678 679 +1
Lines 86918 86960 +42
================================================
+ Hits 64265 64292 +27
- Misses 17854 17865 +11
- Partials 4799 4803 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Update hb fixes 2022.09.07
sasurobert
approved these changes
Sep 7, 2022
schimih
approved these changes
Sep 7, 2022
ssd04
approved these changes
Sep 7, 2022
gabi-vuls
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure