Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/heartbeat fixes #4441

Merged
merged 27 commits into from
Sep 9, 2022
Merged

Feat/heartbeat fixes #4441

merged 27 commits into from
Sep 9, 2022

Conversation

iulianpascalau
Copy link
Contributor

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • heartbeat fixes and optimizations

Proposed Changes

  • fixes and optimizations

Testing procedure

  • standard system test
  • public testnet testing

iulianpascalau and others added 18 commits September 2, 2022 13:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- hb v1 monitor no longer returns data after disable epoch
…rs. metricsUpdater benefits from this, it better updates the metric
Fix hb v2 metrics issues + hb status returned
@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Sep 3, 2022
@iulianpascalau iulianpascalau marked this pull request as ready for review September 7, 2022 14:33
@codecov-commenter
Copy link

Codecov Report

Merging #4441 (b6df88b) into rc/2022-july (b5c57c4) will decrease coverage by 0.00%.
The diff coverage is 86.03%.

@@               Coverage Diff                @@
##           rc/2022-july    #4441      +/-   ##
================================================
- Coverage         73.93%   73.93%   -0.01%     
================================================
  Files               678      679       +1     
  Lines             86918    86960      +42     
================================================
+ Hits              64265    64292      +27     
- Misses            17854    17865      +11     
- Partials           4799     4803       +4     
Impacted Files Coverage Δ
cmd/termui/presenter/chainInfoGetters.go 82.22% <0.00%> (-1.87%) ⬇️
cmd/termui/presenter/instanceInfoGetters.go 80.48% <0.00%> (-4.13%) ⬇️
dataRetriever/interface.go 12.12% <ø> (ø)
node/nodeRunner.go 0.00% <0.00%> (ø)
factory/processComponents.go 53.51% <50.00%> (+0.01%) ⬆️
heartbeat/sender/heartbeatSender.go 91.56% <68.75%> (-5.45%) ⬇️
...t/processor/peerAuthenticationRequestsProcessor.go 94.87% <75.00%> (-1.98%) ⬇️
factory/heartbeatV2Components.go 75.83% <87.50%> (+1.21%) ⬆️
dataRetriever/factory/dataPoolFactory.go 93.26% <100.00%> (-1.93%) ⬇️
...esolverscontainer/baseResolversContainerFactory.go 86.34% <100.00%> (-0.46%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed.

@gabi-vuls gabi-vuls merged commit 662828d into rc/2022-july Sep 9, 2022
@gabi-vuls gabi-vuls deleted the feat/heartbeat-fixes branch September 9, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants