Update rc v1.4.0 2022.09.09 #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hb v1 monitor no longer returns data after disable epoch
…nnections' metrics from monitor
Fix heartbeat v2 metrics update
…rs. metricsUpdater benefits from this, it better updates the metric
Fix hb v2 metrics issues + hb status returned
Add new flags (useful for some observers): "serialize-snapshots", "disable-consensus-watchdog"
Further hb v2 fixes
Update hb fixes 2022.09.07
Feat/heartbeat fixes
# Conflicts: # cmd/node/flags.go # config/contextFlagsConfig.go # factory/stateComponents.go # heartbeat/process/monitor.go # heartbeat/process/monitor_test.go # node/nodeRunner.go
sstanculeanu
reviewed
Sep 9, 2022
| }, | ||
| } | ||
| args.EnableEpochsHandler = &testscommon.EnableEpochsHandlerStub{ | ||
| IsHeartbeatDisableFlagEnabledField: false, |
There was a problem hiding this comment.
Suggested change
| IsHeartbeatDisableFlagEnabledField: false, | |
| IsHeartbeatDisableFlagEnabledField: true, |
SebastianMarian
previously approved these changes
Sep 9, 2022
sstanculeanu
approved these changes
Sep 9, 2022
SebastianMarian
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure