Re-enable note-off for deck A cue button #2086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: res/controllers/American-Audio-RADIUS-2000-scripts.js res/controllers/Behringer-BCD3000-Advanced-scripts.js res/controllers/Behringer-BCD3000-scripts.js res/controllers/Hercules-DJ-Console-Mk4-scripts.js res/controllers/common-hid-packet-parser.js res/skins/Tango/style.qss
This will be used to implement instant doubles.
Also queue the position clone using a special sync request.
If two load operations are attempted in quick succession, a clone will be performed instead of the second load.
Previously the track would start playing as soon as it was loaded but before the position was synced. Some audio would leak out on occasion. Moving these operations closer together reduces this possibility. To completely eliminate it, the seek and the play will need to happen in the engine thread together. Not sure if this will be necessary.
Latenight :. permanent xFader buttons
if neither EQs nor Vol fader are visible so that the xFader doesn't get squeezed is still usable.
Fixing broken bug cover dialog in case no cover is avaiable
numark mixtrack 3: don't change FX level when moving beatgrid
Traktor feature clean up
# Conflicts: # CHANGELOG # src/defs_version.h
Shade :: fix small decks' bg/border colors in color schemes
[WIP] Deere :: simplify mixer templates
I don't know why the note-off for deck A cue button was disabled, but it breaks the hold-cue functionality of Mixxx cue setting and moreover, deck B has both note-on and note-off (and behaves normally) so the configuration was asymmetric anyway?
|
Thank you for this fix. Can you rebase your branch on the 2.2 branch so we can include this in 2.2.2 before 2.3 is released? |
|
I used the github built-in editor, so it's not so easy to rebase... here's a fresh PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the note-off for deck A cue button was disabled, but it breaks the hold-cue functionality of Mixxx cue setting and moreover, deck B has both note-on and note-off (and behaves normally) so the configuration was asymmetric anyway?