Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latenight :. permanent xFader buttons #2075

Merged
merged 5 commits into from
Apr 9, 2019

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Apr 5, 2019

this adds xFader buttons to two deck mixer, as well as a smalller xfader for minimal mixer configurations.

now each character L/M/R can be clicked to directly set the desired deck xfader orientation

latenight-xfader

ronso0 added 4 commits April 4, 2019 14:16
each character [L, M, R] can be clicked separately to directly assign the deck
to the desired side of the crossfader.
no more cycling through the states L > M > R > L...
@ronso0
Copy link
Member Author

ronso0 commented Apr 5, 2019

helps solving the root issue from #2071 "disable crossfader"

@daschuer
Copy link
Member

daschuer commented Apr 6, 2019

Thank you fro working at this. This way you might think that the orientation buttons are configuring the xfader sides. Did you consider to arrange them like in the four decks layout?
The look a little bit lost if you hide the xfader.

In general, I am a little bit worried to clutter the skin with these rarely used buttons. I think the only use case in a two decks layout is to disable the xFader, which is a configuration action and not done during mixing.

Do you like the Idea to move them to the xfader preferences? This can also control showing and hiding the xfader.

@ronso0
Copy link
Member Author

ronso0 commented Apr 6, 2019

This way you might think that the orientation buttons are configuring the xfader sides. Did you consider to arrange them like in the four decks layout?

There's just not enough space in the mixer. Resizing/redesigning slider graphics for this little tweak is not worth the effort.
I guess it helps to push the buttons up a bit so that they appear less attached to the crossfader
55619196-83d60e80-5798-11e9-869e-0851cef9f20c

The look a little bit lost if you hide the xfader.

uups,.. yes they should disappear when the xfader is hidden.

@ronso0
Copy link
Member Author

ronso0 commented Apr 6, 2019

In general, I am a little bit worried to clutter the skin with these rarely used buttons. I think the only use case in a two decks layout is to disable the xFader, which is a configuration action and not done during mixing.

While I agree with you here, I'm reluctant adding another skin option (default on or Off? how to make this discoverable to users who never switch to 4 decks?)
Looking at the picture above (with shifted xfader buttons) I think they don't hurt, but make the picture complete IMO

@ronso0
Copy link
Member Author

ronso0 commented Apr 6, 2019

porting those changes to Deere is going to be a PITA as the mixer templates are hard to maintain.

@daschuer
Copy link
Member

daschuer commented Apr 6, 2019

I am fine with this screenshot now. Is there anything left to do?

Let's discuss the whole issue here:
#2071

@ronso0
Copy link
Member Author

ronso0 commented Apr 6, 2019

I still need to apply the changes from the Screenshot. that'll happen tonight I guess

@ronso0
Copy link
Member Author

ronso0 commented Apr 6, 2019

Ready, steady, ...

@uklotzde uklotzde added this to the 2.3.0 milestone Apr 7, 2019
@ywwg
Copy link
Member

ywwg commented Apr 8, 2019

thank you for this change! it'll be very useful to me. I have no notes :)

@uklotzde
Copy link
Contributor

uklotzde commented Apr 9, 2019

Ready for merge?

@ronso0
Copy link
Member Author

ronso0 commented Apr 9, 2019

I'd say so. I'm already working on the corresponding changes in Deere (for consistency across skins) in another branch.
but the superordinate discussion is going on in #2071

@daschuer
Copy link
Member

daschuer commented Apr 9, 2019

LGTM, Thank you.

@daschuer daschuer merged commit 33fa745 into mixxxdj:master Apr 9, 2019
@ronso0 ronso0 deleted the latenight-xfader-buttons branch April 10, 2019 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants