-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latenight :. permanent xFader buttons #2075
Conversation
each character [L, M, R] can be clicked separately to directly assign the deck to the desired side of the crossfader. no more cycling through the states L > M > R > L...
helps solving the root issue from #2071 "disable crossfader" |
Thank you fro working at this. This way you might think that the orientation buttons are configuring the xfader sides. Did you consider to arrange them like in the four decks layout? In general, I am a little bit worried to clutter the skin with these rarely used buttons. I think the only use case in a two decks layout is to disable the xFader, which is a configuration action and not done during mixing. Do you like the Idea to move them to the xfader preferences? This can also control showing and hiding the xfader. |
While I agree with you here, I'm reluctant adding another skin option (default on or Off? how to make this discoverable to users who never switch to 4 decks?) |
porting those changes to Deere is going to be a PITA as the mixer templates are hard to maintain. |
I am fine with this screenshot now. Is there anything left to do? Let's discuss the whole issue here: |
I still need to apply the changes from the Screenshot. that'll happen tonight I guess |
Ready, steady, ... |
thank you for this change! it'll be very useful to me. I have no notes :) |
Ready for merge? |
I'd say so. I'm already working on the corresponding changes in Deere (for consistency across skins) in another branch. |
LGTM, Thank you. |
this adds xFader buttons to two deck mixer, as well as a smalller xfader for minimal mixer configurations.
now each character L/M/R can be clicked to directly set the desired deck xfader orientation