numark mixtrack 3: don't change FX level when moving beatgrid #2057
Conversation
|
Should the fix be included in 2.2.1? Then please change the target branch of this PR. |
|
The fix is to be included asap, so i guess yes it should be in 2.2.1. I changed the target branch to 2.2 |
|
But now there's a huge number of conflicts, maybe I should rather create another merge request from scratch, based on branch 2.2 ? |
|
Rebasing your local branch on the latest 2.2 should work. Then do a force push and change the target branch afterwards. Creating a new PR would be the last resort. |
|
You can re-write and force push your local branch in any way as long as you keep its name. PRs are bound to the URL, i.e. the branch name. |
|
Simply changing the target branch doesn't work:
|
|
We also need the permission to distribute your changes by signing the Mixxx contributor agreement. |
|
Considering this has gotten a 👍 from @radusuciu who has this controller, LGTM. |
FYI I no longer have this controller, but the change is minor and it's relatively easy to see the consequence. |
|
Thank you! |
|
And cherry-picked to 2.2 ad33458 |
|
This bug sound quite similar: https://bugs.launchpad.net/bugs/1825659 are they related? |
|
hello I made some change before him. But I didn't make commits yet. I really don't understand why it happens............ this bug is very annoying. |
controller mapping bugfix for Numark Mixtrack Pro 3: when moving the beatgrid forward or backward with TAP + FX level, it has the buggy side effect of changing the FX level. This commit fixes that.