Traktor feature clean up #2084
Merged
Traktor feature clean up #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
reviewed
Apr 20, 2019
| #else | ||
| location = volume; | ||
| #endif | ||
| location += path.replace(QString(":"), QString("")); | ||
| // Traktor uses /: instead of just / as delimiting character for some reasons | ||
| location += path.replace("/:", "/"); |
There was a problem hiding this comment.
Good finding. The replacement is done twice (see below), so moving it into an inlined function (including the comment) would be even better.
|
Good finding 👍 The code before was actually buggy and tried to fix the shortcomings with an ugly workaround. |
|
Done. Thank you for review. |
|
LGTM. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tweaked the Traktor feature that it is testable on Linux as well.