Bugfix #1535 #3467
Closed
Bugfix #1535 #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoft#3426) * Preventing up/down arrow key presses from bubbling and triggering the browser default handler. * Change file
* give new textfield examples the right max width * added a change file * Update max-width-fix_2017-11-20-23-53.json
…Cells (microsoft#3429) * added white cell border * added white border to white color cell * cleanup * add change list * added null check; style fix * moved white cell style behind if check * cleaned up style * fixed lint problems * got rid of type casting
* Add small header with margin and wide callout * Add change file * Remove unneeded change * unneeded change 2 * Add story test and update comment * Update TeachingBubble.stories.tsx
…he width of the target (microsoft#3431) * Add useTargetAsMinWidth prop * Rush change
* Apply props.className in ResizeGroup. Add snapshot for ResizeGroup. Pass className from experiments CommandBarTests. Update experiments CommandBar snapshot * Committing change files * Fix change file
… with the target element (microsoft#3402) * changing combobox dropdown calculation * deleting unused variable * creating change file * changing the width to match dropdown style * moving dropdown prop into combobox prop
…oft#3451) * ComboBox on up/down arrow keys should just update the pending index and values. It should not update the selected value. The selected value always should only be updated on blur, enter, space, tab key presses only * Change file * Spelling correction
microsoft#3444) * Fixed replaced example * updated styles to match toolkit * Added change files * updated deprecated sematic slots * Update contextualmenu-bug_2017-11-21-19-43.json * Update contextualmenu-bug_2017-11-21-19-43.json
* Button: new prop splitButtonAriaLabel. * Change details. * Update new prop jsdoc.
…ft#3421) * New aria label example, split out * Split out aria label example * Added change file
|
Please provide a more detailed PR title and description. Include the name of the component, details of the bug, and how it will be fixed |
|
Also, be sure to include a change file using |
lynamemi
reviewed
Nov 28, 2017
| @@ -591,25 +591,25 @@ $Calendar-dayPicker-margin: 10px; | |||
| } | |||
|
|
|||
| .monthIsHighlighted { | |||
| background-color: $ms-color-themeLight; | |||
| background-color: $ms-color-themeLight !important; | |||
There was a problem hiding this comment.
!important raises red flags - should be a last resort
There was a problem hiding this comment.
agreed. this will break anyone downstream that is trying to theme their calendar.
|
It looks like the build error you're getting is from jest snapshots. It's finding the change you made from span to button. Follow this documentation to update the snapshots: |
|
Closing for now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Changed spans into buttons
added CSS so that layout of the page would look similar
added !important to certain styles so that the CSS I added would not interfere with other portions of the design.
Focus areas to test
I tested other areas of the application to verify that changes did not affect other portions of the application.