Button: new prop splitButtonAriaLabel #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdahamiwal
reviewed
Nov 21, 2017
| @@ -116,6 +116,11 @@ export interface IButtonProps extends React.AllHTMLAttributes<HTMLAnchorElement | |||
| */ | |||
| menuIconProps?: IIconProps; | |||
|
|
|||
| /** | |||
| * The title to announce the dropdown button if this button is split. | |||
There was a problem hiding this comment.
Accessible label for cheveron icon if this button is split
mdahamiwal
approved these changes
Nov 21, 2017
dzearing
approved these changes
Nov 23, 2017
taggie05
pushed a commit
to taggie05/office-ui-fabric-react
that referenced
this pull request
Nov 27, 2017
* Button: new prop splitButtonAriaLabel. * Change details. * Update new prop jsdoc.
ohritz
pushed a commit
to ohritz/office-ui-fabric-react
that referenced
this pull request
Dec 5, 2017
* Button: new prop splitButtonAriaLabel. * Change details. * Update new prop jsdoc.
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
* Button: new prop splitButtonAriaLabel. * Change details. * Update new prop jsdoc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
For accessibility, we need to be able to specify
aria-labelin the dropdown button of a split button, so it's correctly announced by screen readers. Note we may need 2 aria-labels, one for the main button and one for the dropdown.I've added prop
splitButtonAriaLabelto fill this gap.I've discarded a more complete approach like a
splitButtonPropsto specify any other prop of that button, because I didn't want to compromise the button evolution so much. If you think that it is a better approach, I'll be happy to update this PR to it.Focus areas to test
Split button. Added aria-label to the first split button example.