ContextualMenu: Updated styles for expanded menu item to match toolkit #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phkuo
reviewed
Nov 22, 2017
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "ContextualMenu: Updated exampanded menu item style to match toolkit.", |
There was a problem hiding this comment.
example + expanded! 😄
phkuo
reviewed
Nov 22, 2017
| @@ -40,7 +40,7 @@ $buttonTextCheckedHoveredColor: "[theme:buttonTextCheckedHovered, default: #0000 | |||
|
|
|||
| /* Menus */ | |||
| $menuItemBackgroundHoveredColor: "[theme:menuItemBackgroundHovered, default: #f8f8f8]"; | |||
| $menuItemBackgroundCheckedColor: "[theme:menuItemBackgroundChecked, default: #d0d0d0]"; | |||
| $menuItemBackgroundCheckedColor: "[theme:menuItemBackgroundChecked, default: #eaeaea]"; | |||
There was a problem hiding this comment.
i thought we were going to set it to no background?
There was a problem hiding this comment.
Can you elaborate?
There was a problem hiding this comment.
@lynamemi I thought the design was to have it have a white, blank background, but ignore me if that's the case.
There was a problem hiding this comment.
nevermind, I thought this was something else
phkuo
approved these changes
Nov 22, 2017
taggie05
pushed a commit
to taggie05/office-ui-fabric-react
that referenced
this pull request
Nov 27, 2017
microsoft#3444) * Fixed replaced example * updated styles to match toolkit * Added change files * updated deprecated sematic slots * Update contextualmenu-bug_2017-11-21-19-43.json * Update contextualmenu-bug_2017-11-21-19-43.json
ohritz
pushed a commit
to ohritz/office-ui-fabric-react
that referenced
this pull request
Dec 5, 2017
microsoft#3444) * Fixed replaced example * updated styles to match toolkit * Added change files * updated deprecated sematic slots * Update contextualmenu-bug_2017-11-21-19-43.json * Update contextualmenu-bug_2017-11-21-19-43.json
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
microsoft#3444) * Fixed replaced example * updated styles to match toolkit * Added change files * updated deprecated sematic slots * Update contextualmenu-bug_2017-11-21-19-43.json * Update contextualmenu-bug_2017-11-21-19-43.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Before
After
Focus areas to test
(optional)