ContextualMenu: Add a prop for setting the min width to be equal to the width of the target #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That last menu looks about 3-5px wider than the target. Looks like a bug |
|
Yeah, I noticed that as well. It repros with the "useTargetWidth" prop as well, so it's something that should be addressed in a follow up PR. Tracked with #3433, not assigning to myself yet since I don't have bandwidth at the moment to take this fix. |
micahgodbolt
approved these changes
Nov 22, 2017
taggie05
pushed a commit
to taggie05/office-ui-fabric-react
that referenced
this pull request
Nov 27, 2017
…he width of the target (microsoft#3431) * Add useTargetAsMinWidth prop * Rush change
ohritz
pushed a commit
to ohritz/office-ui-fabric-react
that referenced
this pull request
Dec 5, 2017
…he width of the target (microsoft#3431) * Add useTargetAsMinWidth prop * Rush change
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this pull request
Apr 17, 2018
…he width of the target (microsoft#3431) * Add useTargetAsMinWidth prop * Rush change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
It is often desired that menus are never narrower than the button that launched them. An example of the undesired situation is shown below:
This change adds a new optional prop "useTargetAsMinWidth" which will use the offset width of the target element as the minimum width of the menu, resulting in something like this:
This is different from the useTargetWidth prop, as useTargetAsMinWidth allows the width of the menu to be wider than that of the target.