Tooltip : updated tooltip styles #28264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 591 | 623 | 5000 | |
| Button | mount | 289 | 294 | 5000 | |
| Field | mount | 1060 | 1081 | 5000 | |
| FluentProvider | mount | 663 | 669 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 81 | 71 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 78 | 10 | |
| InfoButton | mount | 13 | 16 | 5000 | |
| MakeStyles | mount | 855 | 857 | 50000 | |
| Persona | mount | 1670 | 1625 | 5000 | |
| SpinButton | mount | 1351 | 1380 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9b5b3f33ad05e2dce6457c72b9e5ffa352033e47 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6dddb8:
|
📊 Bundle size report
Unchanged fixtures
|
behowell
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Hi @kkakroo, thanks for the PR. Unfortunately it looks like this approach breaks the withArrow styles, probably because the overflow: hidden style clips the arrow. Additionally, we'd prefer to avoid clipping/ellipsifying the tooltip content if possible, since the point of the tooltip is to show additional information.
It looks like overflowWrap: 'break-word' would be a reasonable fix for the linked issue. If you'd like you can update this PR with that style, or I can make a PR with that change.
Also, please put the style on the 'root' class; the 'visible' class is just about controlling visibility.
|
Hi @behowell , thanks for the comment. |
behowell
reviewed
Jun 20, 2023
change/@fluentui-react-tooltip-0c7f8278-85ad-44f1-82b3-8048cf63b2e7.json
Outdated
Show resolved
Hide resolved
behowell
reviewed
Jun 20, 2023
|
@behowell , added VR tests as requested. |
fabricteam
reviewed
Jun 20, 2023
behowell
approved these changes
Jun 20, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 21, 2023
* master: Fixed bugs and added more stories to the Breadcrumb (microsoft#28267) refactor: Keep vanillajs code only where needed (microsoft#28278) fix: correcting focus behavior of react-search (microsoft#28241) Tooltip : updated tooltip styles (microsoft#28264)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 22, 2023
* master: (95 commits) docs(react-drawer): improve drawer stories examples (microsoft#28283) bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272) Doc: Tree Infinite Scrolling (microsoft#28197) fix(react-card): infer a11y id from immediate header element (microsoft#28266) Fixed bugs and added more stories to the Breadcrumb (microsoft#28267) refactor: Keep vanillajs code only where needed (microsoft#28278) fix: correcting focus behavior of react-search (microsoft#28241) Tooltip : updated tooltip styles (microsoft#28264) applying package updates feat(react-tags): add styles for size (microsoft#28229) docs(react-dialog): update DialogTriggerOutsideDialog to include focus behavior (microsoft#28176) bugfix: Ensures dialog actions stretches on breakpoints (microsoft#28258) applying package updates fix: TableHeaderCell should not render button when not sortable (microsoft#28097) fix(react-file-type-icons): Map mhtml extension to html icon (microsoft#28112) Fix overlapping axis labels on smaller viewports (microsoft#28239) useArrowNavigationGroup grid-linear axis (microsoft#28253) applying package updates fix: Alert example missing aria-label for icon (microsoft#28234) Overflow divider fix (microsoft#28011) ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 22, 2023
* master: docs(react-drawer): best practices (microsoft#28040) docs(react-drawer): add missing documentation for Drawer stories (microsoft#28284) docs(react-drawer): improve type descriptions and fix TS circular references (microsoft#28282) docs(react-drawer): improve drawer stories examples (microsoft#28283) bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272) Doc: Tree Infinite Scrolling (microsoft#28197) fix(react-card): infer a11y id from immediate header element (microsoft#28266) Fixed bugs and added more stories to the Breadcrumb (microsoft#28267) refactor: Keep vanillajs code only where needed (microsoft#28278) fix: correcting focus behavior of react-search (microsoft#28241) Tooltip : updated tooltip styles (microsoft#28264)
|
🎉 Handy links: |
2 tasks
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Tooltip content exceeds its container when long text is added
New Behavior
Tooltip content gets trimmed with ellipsis when long text is added
Related Issue(s)