fix: TableHeaderCell should not render button when not sortable #28097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the approach with the smallest impact to API and slot rendering. The slot rendered a native `button` always, but with role="presentation" when it was not interactive. The slot always renders a `div` but with ARIA button semantics when it is interactive Fixes microsoft#27633
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1a277b9c4d55bc1b7c65a73383425b1934ec1dad (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 65 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 597 | 582 | 5000 | |
| Button | mount | 297 | 296 | 5000 | |
| Field | mount | 1036 | 1034 | 5000 | |
| FluentProvider | mount | 684 | 656 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 59 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 65 | 65 | 10 | Possible regression |
| InfoButton | mount | 9 | 11 | 5000 | |
| MakeStyles | mount | 859 | 831 | 50000 | |
| Persona | mount | 1674 | 1595 | 5000 | |
| SpinButton | mount | 1265 | 1323 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ffc1fd1:
|
📊 Bundle size report
Unchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
reviewed
Jun 8, 2023
packages/react-components/react-table/src/components/TableHeaderCell/TableHeaderCell.types.ts
Outdated
Show resolved
Hide resolved
ling1726
commented
Jun 19, 2023
packages/react-components/react-table/src/components/TableHeaderCell/TableHeaderCell.types.ts
Outdated
Show resolved
Hide resolved
bsunderhus
approved these changes
Jun 19, 2023
|
🎉 Handy links: |
|
🎉 Handy links: |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 20, 2023
* master: (32 commits) applying package updates feat(react-tags): add styles for size (microsoft#28229) docs(react-dialog): update DialogTriggerOutsideDialog to include focus behavior (microsoft#28176) bugfix: Ensures dialog actions stretches on breakpoints (microsoft#28258) applying package updates fix: TableHeaderCell should not render button when not sortable (microsoft#28097) fix(react-file-type-icons): Map mhtml extension to html icon (microsoft#28112) Fix overlapping axis labels on smaller viewports (microsoft#28239) useArrowNavigationGroup grid-linear axis (microsoft#28253) applying package updates fix: Alert example missing aria-label for icon (microsoft#28234) Overflow divider fix (microsoft#28011) feat(tools): implement `cypress-component-configuration` generator (microsoft#28115) chore: migrate to TS 4.7 (microsoft#28067) fix(scripts-tasks): make generate-api work in deterministic way (microsoft#28215) feat(react-tags): add overflow story (microsoft#28012) Structure and slots for SearchBox, using Input as a slot (microsoft#28090) feat(tokens): Add/update theme tokens (microsoft#27791) feat(react-tags): add a11y role and best practices guide (microsoft#28075) fix: Toast intent should always be present in the context (microsoft#28226) ...
|
🎉 Handy links: |
|
🎉 Handy links: |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 22, 2023
* master: (95 commits) docs(react-drawer): improve drawer stories examples (microsoft#28283) bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272) Doc: Tree Infinite Scrolling (microsoft#28197) fix(react-card): infer a11y id from immediate header element (microsoft#28266) Fixed bugs and added more stories to the Breadcrumb (microsoft#28267) refactor: Keep vanillajs code only where needed (microsoft#28278) fix: correcting focus behavior of react-search (microsoft#28241) Tooltip : updated tooltip styles (microsoft#28264) applying package updates feat(react-tags): add styles for size (microsoft#28229) docs(react-dialog): update DialogTriggerOutsideDialog to include focus behavior (microsoft#28176) bugfix: Ensures dialog actions stretches on breakpoints (microsoft#28258) applying package updates fix: TableHeaderCell should not render button when not sortable (microsoft#28097) fix(react-file-type-icons): Map mhtml extension to html icon (microsoft#28112) Fix overlapping axis labels on smaller viewports (microsoft#28239) useArrowNavigationGroup grid-linear axis (microsoft#28253) applying package updates fix: Alert example missing aria-label for icon (microsoft#28234) Overflow divider fix (microsoft#28011) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the approach with the smallest impact to API and slot rendering.
Previous Behavior
The slot rendered a native
buttonalways, but with role="presentation" when it was not interactive.New Behavior
The slot renders a
divby default but with ARIA button semantics when it is interactiveRelated Issue(s)
Fixes #27633