Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correcting focus behavior of react-search #28241

Merged
merged 17 commits into from
Jun 21, 2023
Merged

fix: correcting focus behavior of react-search #28241

merged 17 commits into from
Jun 21, 2023

Conversation

emmayjiang
Copy link
Contributor

  • Polishes the appearances of react-search based on the selected size and appearance
  • Add the appear-on-focus behavior to the contentAfter and dismiss icons
  • Enables excluding contentAfter while still maintaining the dismiss button
image

@emmayjiang emmayjiang requested a review from a team as a code owner June 16, 2023 17:36
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 16, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 64fb6d6be07cd309c26a49d6fa31ed60e7030c79

@size-auditor
Copy link

size-auditor bot commented Jun 16, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 64fb6d6be07cd309c26a49d6fa31ed60e7030c79 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 16, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d6d4d53:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

smhigley
smhigley reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some minor comments

@smhigley
Copy link
Contributor

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

smhigley
smhigley reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, then this looks good to go!

@emmayjiang emmayjiang enabled auto-merge (squash) June 21, 2023 00:22
@emmayjiang emmayjiang merged commit 5809e04 into microsoft:master Jun 21, 2023
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 21, 2023
@marcosmoura
Merge branch 'master' into docs/react-drawer-stories-improvement
494af63 
* master:
  Fixed bugs and added more stories to the Breadcrumb (microsoft#28267)
  refactor: Keep vanillajs code only where needed (microsoft#28278)
  fix: correcting focus behavior of react-search (microsoft#28241)
  Tooltip : updated tooltip styles (microsoft#28264)
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 22, 2023
@marcosmoura
Merge branch 'master' into docs/react-drawer-best-practices
094ec9f 
* master: (95 commits)
  docs(react-drawer): improve drawer stories examples (microsoft#28283)
  bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272)
  Doc: Tree Infinite Scrolling (microsoft#28197)
  fix(react-card): infer a11y id from immediate header element (microsoft#28266)
  Fixed bugs and added more stories to the Breadcrumb (microsoft#28267)
  refactor: Keep vanillajs code only where needed (microsoft#28278)
  fix: correcting focus behavior of react-search (microsoft#28241)
  Tooltip : updated tooltip styles (microsoft#28264)
  applying package updates
  feat(react-tags): add styles for size (microsoft#28229)
  docs(react-dialog): update DialogTriggerOutsideDialog to include focus behavior (microsoft#28176)
  bugfix: Ensures dialog actions stretches on breakpoints (microsoft#28258)
  applying package updates
  fix: TableHeaderCell should not render button when not sortable (microsoft#28097)
  fix(react-file-type-icons): Map mhtml extension to html icon (microsoft#28112)
  Fix overlapping axis labels on smaller viewports (microsoft#28239)
  useArrowNavigationGroup grid-linear axis (microsoft#28253)
  applying package updates
  fix: Alert example missing aria-label for icon (microsoft#28234)
  Overflow divider fix (microsoft#28011)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Jun 22, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
d2df033 
* master:
  docs(react-drawer): best practices (microsoft#28040)
  docs(react-drawer): add missing documentation for Drawer stories (microsoft#28284)
  docs(react-drawer): improve type descriptions and fix TS circular references (microsoft#28282)
  docs(react-drawer): improve drawer stories examples (microsoft#28283)
  bugfix: adds grid-template-columns to DialogBody styles to ensure grid template layout (microsoft#28272)
  Doc: Tree Infinite Scrolling (microsoft#28197)
  fix(react-card): infer a11y id from immediate header element (microsoft#28266)
  Fixed bugs and added more stories to the Breadcrumb (microsoft#28267)
  refactor: Keep vanillajs code only where needed (microsoft#28278)
  fix: correcting focus behavior of react-search (microsoft#28241)
  Tooltip : updated tooltip styles (microsoft#28264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees

@marcosmoura marcosmoura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emmayjiang @fabricteam @smhigley @spmonahan @marcosmoura