OnReceive is only run if all relevant Middleware Complete #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging changes back to master.
Adding test case for aggregate exception
Extracted QnAMaker logic from corresponding middleware
Auth cleanup
Updated QnAMaker to use v3 API
…ft/botbuilder-dotnet into CLM/RunOnReceiveAtTheEnd
|
Rebased against master to enable clean merge. |
johnataylor
approved these changes
Feb 19, 2018
|
|
||
| return results.Answers.Where(answer => answer.Score > _options.ScoreThreshold).ToArray(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Perhaps a trace would be useful here - QnA service returning a failure.
There was a problem hiding this comment.
Agreed. That's part of a different PR (someone else did it) that's only showing up here because I rebased my PR against master to make merging cleaner.
| /// <summary> | ||
| /// TO BOT FROM CHANNEL: Token validation parameters when connecting to a bot | ||
| /// </summary> | ||
| public static readonly TokenValidationParameters ToBotFromChannelTokenValidationParameters = | ||
| new TokenValidationParameters() | ||
| { | ||
| ValidateIssuer = true, | ||
| ValidIssuers = new[] { AuthenticationConstants.BotFrameworkTokenIssuer }, | ||
| ValidIssuers = new[] { AuthenticationConstants.ToBotFromChannelTokenIssuer }, |
There was a problem hiding this comment.
This looks like an unrelated fix?
There was a problem hiding this comment.
@johnataylor Correct. That's showing up in this PR due to the rebasing against master. That was part of a PR (that's already accepted + merged) that Dan did earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#130
This alters the behavior of the Bot, so that OnReceive is ONLY called if all relevant Middleware completes. If any middleware fails to call next, or throws, the the OnReceive handler will not be called. Based on consenus in #130, this is the desired behavior.
The only "edge" case is a Pipeline with no relevant Middleware. I've defined this as "Run OnReceive if there is no Middleware". This seems the correct behavior.
Relevant tests around this have been added testing the various conditions.