Adding test case for aggregate exception #147
Conversation
Merging changes back to master.
|
Looking now. Thanks! |
|
After pulling in your changes and the changes to TestAdapter by @drub0y , my test required no changes. Let me know if you notice anything off! |
| @@ -154,5 +156,26 @@ await adapter | |||
| .AssertReply("three") | |||
| .StartTest(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
Isn't this supposed to be DataTestMethod?
There was a problem hiding this comment.
The docs are not much help, unfortunatly:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.testtools.unittesting.datatestmethodattribute?view=mstest-net-1.2.0
There was a problem hiding this comment.
Never mind. I tested the code. It worked fine as-is.
| @@ -154,5 +156,26 @@ await adapter | |||
| .AssertReply("three") | |||
| .StartTest(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
Never mind. I tested the code. It worked fine as-is.
|
Thanks Ryan! I think this is a great addition to the tests. Already tonight, with the Exception improvements to the Test Adapter, I've caught bugs that previously were slipping through. Having the exceptions flow through correctly has been a huge help! |
|
@cleemullins Sweet. I'll try and monitor the issues if you post them. |
This PR is a remake of #142 to pull to master instead of the PassExceptionsOnTaskFaults branch.