Extracted QnAMaker logic from corresponding middleware #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks! I’ll take a look through this later, and make sure the tests pass. |
cleemullins
approved these changes
Feb 18, 2018
|
Thanks!!!! |
ceciliaavila
pushed a commit
that referenced
this pull request
Jul 1, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Jul 12, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Jul 12, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Jul 24, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Jul 27, 2019
gasper-az
pushed a commit
that referenced
this pull request
Aug 15, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 5, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 10, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 11, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 11, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 13, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 16, 2019
ceciliaavila
pushed a commit
that referenced
this pull request
Sep 18, 2019
ShYuPe
pushed a commit
to ShYuPe/botbuilder-dotnet
that referenced
this pull request
Aug 25, 2020
Feature parity with C# and JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
GetAnswerslogic to separate class that is used in middleware and can be reused without it. There are test for QnA but they are commented and i don`t know how to run them.@drub0y @daltskin
Closes #124 and i believe #137 as well.