Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth cleanup #154

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Auth cleanup #154

merged 3 commits into from
Feb 19, 2018

Conversation

dandriscoll
Copy link
Member

Fixes:

  • Comments
  • Removes v3.x token checks, since they don't exist as token versions
  • Moves constants into AuthenticationConstants.cs. We already had some emulator- and channel-specific constants there and I figured people would rather go toward centralizing than splitting.

cleemullins
cleemullins approved these changes Feb 19, 2018
View reviewed changes
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That review really drives home that I stink at spelling.

@cleemullins cleemullins merged commit cd1a296 into microsoft:master Feb 19, 2018
@enzocano enzocano mentioned this pull request Feb 20, 2018
Merged
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this pull request Aug 25, 2020
@axelsrz
Merge pull request microsoft#154 from daveta/daveta-django-tests
f462db6 
Add Application Insights Django-specific tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dandriscoll @cleemullins