-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROJECT] Move embedded css-examples into content #597
Comments
@mdn/localization-team-leads this is going to be relevant :) If you need a hand with changes or reviewing the translated versions, please |
@bsmth, I created a PR, and it seems to be working well. cc. @mdn/yari-content-ko Additionally.. https://github.com/mdn/translated-content/pull/24284/files ### Example showing different durations
...
{{EmbedLiveSample("Example_showing_different_durations",275,200)}} If the existing Markdown title is specified as EmbedLiveSample, it would be better to update it to the following syntax too. \```html live-sample___specificity-simple
...
\```
\```css live-sample___specificity-simple
...
\```
{{EmbedLiveSample("specificity-simple")}} |
Super, your PR looks good, thank you! I'm making small edits on each new mdn/content PR to tidy up examples, and your PR includes those changes, so I'm happy!
This syntax |
Thank you :) I requested docs access to see the applied content repo range. Could you please approve it? Or, I’d like to apply the updates to the |
Done ✅
Yes, that would be the best thing to do for now; wait until each PR has landed on mdn/content first, the content may go out of sync if we do them in a different order. Thank you! |
As part of an initiative to reduce repo maintenance & code duplication, we'll be moving external examples into content, starting with embedded examples, and specifically CSS examples. Some automation work to speed this up is done on mdn/content@main...bsmth:content:css-examples-transfer, but to avoid one large PR which is not detail-focused, let's take our time to make sure the content looks and works great in smaller pieces.
How to help (en-US
mdn/content
):Instead of copying and pasting from the diffs, you can try the following approach:
At this point, you should have changes ready to be tidied up, and you can open a PR when ready.
Check the following:
Things not to do:
playable.js
&styles.css
) or assetsIf you're unsure, you can ask, or highlight things as unsure in the PR.
How to help (Translated content):
When a PR is merged, you can help by porting the changes from mdn/content@main to translated-content. This will be really important to make sure translated versions don't get left behind with this project.
Why:
There are a few reasons why we are moving the examples:
Tracking sheet: https://docs.google.com/spreadsheets/d/1v1gmrJDX7ALXEiRmPKBpVbCXRCdVOGJm2-zQ7qj1cJo/edit?gid=0#gid=0
The text was updated successfully, but these errors were encountered: