Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] chore(CSS): Tidy up CSS backgrounds and borders live samples #24297

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

hochan222
Copy link
Member

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/color.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/background-image.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/repeat.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/size.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/position.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/gradients.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/multiple-background-image.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/background.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/borders.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/backgrounds-borders/corners.html", '100%', 800)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@hochan222 hochan222 requested a review from a team as a code owner November 1, 2024 01:04
@hochan222 hochan222 requested review from sunhpark42 and removed request for a team November 1, 2024 01:04
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Preview URLs

Flaws (6)

URL: /ko/docs/Learn/CSS/Building_blocks/Backgrounds_and_borders
Title: 배경 및 테두리
Flaw count: 6

  • macros:
    • /ko/docs/Web/CSS/background-size does not exist but fell back to /en-US/docs/Web/CSS/background-size
    • /ko/docs/Web/CSS/background-position does not exist but fell back to /en-US/docs/Web/CSS/background-position
    • /ko/docs/Web/CSS/background-position-x does not exist but fell back to /en-US/docs/Web/CSS/background-position-x
    • /ko/docs/Web/CSS/background-position-y does not exist but fell back to /en-US/docs/Web/CSS/background-position-y
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (10 in common of 11 possible)
External URLs (2)

URL: /ko/docs/Learn/CSS/Building_blocks/Backgrounds_and_borders
Title: 배경 및 테두리

(comment last updated: 2024-12-10 11:21:23)

hochan222 and others added 3 commits November 1, 2024 10:07
…ex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ex.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jan 11, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jan 15, 2025
@hochan222 hochan222 enabled auto-merge (squash) January 15, 2025 10:05
@hochan222 hochan222 merged commit 72bd9b8 into mdn:main Jan 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants