Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): Move CSS examples - Pseudo-classes and pseudo-elements #36580

Merged
merged 1 commit into from
Oct 30, 2024
Merged

chore(css): Move CSS examples - Pseudo-classes and pseudo-elements #36580

merged 1 commit into from
Oct 30, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Oct 30, 2024

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/learn/selectors/first-child.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/first-child2.html", '100%', 700)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/hover.html", '100%', 500)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/first-line.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/before.html", '100%', 400)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/after-icon.html", '100%', 400)}}
{{EmbedGHLiveSample("css-examples/learn/selectors/before-styled.html", '100%', 500)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@bsmth bsmth requested a review from a team as a code owner October 30, 2024 17:41
@bsmth bsmth requested review from estelle and removed request for a team October 30, 2024 17:41
@github-actions github-actions bot added Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed labels Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs

estelle
estelle approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estelle estelle merged commit 26a8765 into mdn:main Oct 30, 2024
7 checks passed
fiji-flo pushed a commit that referenced this pull request Oct 31, 2024
@bsmth @fiji-flo
chore(css): Move CSS examples - Pseudo-classes and pseudo-elements (#…
2763fbd 
…36580)
@bsmth bsmth deleted the css-box-model branch November 1, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

Assignees
No one assigned
Labels
Content:Learn:CSS Learning area CSS docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @estelle