Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): Move CSS examples - imageset, fonts #36772

Merged
merged 8 commits into from
Nov 14, 2024
Merged

chore(css): Move CSS examples - imageset, fonts #36772

merged 8 commits into from
Nov 14, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Nov 13, 2024 •
edited
Loading

This PR moves some CSS external examples into content as part of an initiative to reduce repo maintenance and code duplication.

/cc @bsmth

@OnkarRuikar OnkarRuikar requested review from a team as code owners November 13, 2024 12:38
@OnkarRuikar OnkarRuikar requested review from estelle and hamishwillee and removed request for a team November 13, 2024 12:38
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Meta Content in the meta docs size/xl [PR only] >1000 LoC changed labels Nov 13, 2024
@OnkarRuikar OnkarRuikar force-pushed the move-css-exmamples-image-set branch from 060bcb3 to 44c35b1 Compare November 13, 2024 12:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

Preview URLs (9 pages)

(comment last updated: 2024-11-14 10:31:02)

@bsmth bsmth self-requested a review November 13, 2024 15:59
OnkarRuikar and others added 3 commits November 14, 2024 10:02
@OnkarRuikar @bsmth
Apply suggestions from code review
4bcb5f0 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@OnkarRuikar
change order in east asian glyph examples
555e535
@OnkarRuikar @bsmth
Update files/en-us/web/css/css_fonts/variable_fonts_guide/index.md
1df71d0 
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
bsmth
bsmth approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I think we can merge shortly!

@bsmth bsmth merged commit ad6eb6b into mdn:main Nov 14, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the move-css-exmamples-image-set branch November 15, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

@hamishwillee hamishwillee Awaiting requested review from hamishwillee hamishwillee is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Meta Content in the meta docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnkarRuikar @bsmth