Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Move CSS examples - CSS values and units #24300

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

hochan222
Copy link
Member

Description

As part of an initiative to reduce repo maintenance & code duplication, this PR moves some external examples into content. This PR converts the following macros to live samples:

{{EmbedGHLiveSample("css-examples/learn/values-units/length.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/em-rem.html", '100%', 1100)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/percentage.html", '100%', 1000)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/percentage-fonts.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/opacity.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-keywords.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-hex.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-rgb.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-rgba.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-hsl.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/color-hsla.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/image.html", '100%', 900)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/position.html", '100%', 800)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/strings-idents.html", '100%', 600)}}
{{EmbedGHLiveSample("css-examples/learn/values-units/calc.html", '100%', 500)}}

Motivation

Motivation is described in the project issue.

Related issues and pull requests

@hochan222 hochan222 requested a review from a team as a code owner November 1, 2024 02:21
@hochan222 hochan222 requested review from sunhpark42 and removed request for a team November 1, 2024 02:21
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Nov 1, 2024
@@ -2,25 +2,29 @@
title: CSS 값과 단위
slug: Learn/CSS/Building_blocks/Values_and_units
l10n:
sourceCommit: 751d58669499de0c6ea0d5b356e0e1448418c5d3
sourceCommit: ff2893c6e14249c44e54c67102ca4218f08b70d1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최신화는 해당 해쉬까지만 진행했습니다.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Preview URLs

Flaws (100)

URL: /ko/docs/Learn/CSS/Building_blocks/Values_and_units
Title: CSS 값과 단위
Flaw count: 100

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/CSS/Building_blocks/Advanced_styling_effects does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Advanced_styling_effects
    • and 89 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/CSS/All_About_The_Containing_Block
    • Can't resolve /ko/docs/Web/CSS/All_About_The_Containing_Block
    • Can't resolve /ko/docs/Web/CSS/CSS_Logical_Properties#블록_치수
    • Can't resolve /ko/docs/Web/CSS/CSS_Logical_Properties#인라인_치수
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (16 in common of 17 possible)

(comment last updated: 2024-11-01 02:30:30)

hochan222 and others added 2 commits November 1, 2024 11:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hochan222 hochan222 requested review from 1ilsang and removed request for sunhpark42 November 1, 2024 02:32
Copy link
Member

@1ilsang 1ilsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일은 특히 쉽지 않았을 것 같은데 고생하셨습니다. 👍

LGTM

@1ilsang 1ilsang merged commit 60e40d4 into mdn:main Nov 2, 2024
7 checks passed
@hochan222 hochan222 deleted the css-values-units branch November 2, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants