-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fr] Dictionary additions #10916
[fr] Dictionary additions #10916
Conversation
WalkthroughThe pull request introduces multiple updates to the French language module of LanguageTool, specifically enhancing the vocabulary by adding new entries to three files: Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
🔥 Files not summarized due to errors (1)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt: Error: Server error: no LLM provider could handle the message
✅ Files skipped from review due to trivial changes (1)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt
🔇 Additional comments (13)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (7)
356-356
: LGTM: New entry for "gravel" added correctly.The entry follows the correct format and provides appropriate part-of-speech tags.
357-357
: LGTM: New entry for "ANSM" added correctly.The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be an acronym.
358-358
: LGTM: New entry for "Gojira" added correctly.The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be a proper noun.
359-359
: LGTM: New entry for "Tetris" added correctly.The entry follows the correct format and provides appropriate part-of-speech tags for the proper noun "Tetris".
360-360
: LGTM: New entry for "Marculfe" added correctly.The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be a proper noun.
361-364
: LGTM: New entries for "bilié" and its variations added correctly.The entries follow the correct format and provide appropriate part-of-speech tags for all forms (masculine/feminine, singular/plural) of the adjective "bilié".
356-364
: Summary: All new dictionary entries have been added correctly.The changes to this file introduce 9 new entries to the French language dictionary. All entries follow the correct format (fullform;baseform;postags) and provide appropriate part-of-speech tags. The additions include nouns, proper nouns, and adjectives, expanding the vocabulary available for processing.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (5)
4810-4810
: Entry for "Jean-Luc Bizien" looks good.The new entry "Jean-Luc Bizien;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s), which is appropriate for a person's name.
4811-4811
: Excellent addition of "body shaming".The entry "body shaming;N m s" is correctly formatted and tagged. Its inclusion as a noun (N), masculine (m), and singular (s) is appropriate. This modern term enhances the lexicon's coverage of contemporary concepts.
4812-4812
: Entry for "Daniel Arsand" is correct.The new entry "Daniel Arsand;Z m s" is properly formatted and tagged as a proper noun (Z), masculine (m), and singular (s), which is appropriate for a person's name.
4813-4813
: Excellent addition of "Petit Poucet".The entry "Petit Poucet;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s). This addition enhances the lexicon's coverage of important cultural references in French folklore.
4814-4814
: Great addition of "Docteur Strange".The entry "Docteur Strange;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s). The use of the French spelling "Docteur" is appropriate. This addition enhances the lexicon's coverage of modern pop culture references.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1)
34708-34712
:⚠️ Potential issueReview of new dictionary entries
Thank you for adding these new entries to the French dictionary. I have a few observations and questions:
The word "romandisme" is duplicated. This is likely an error and one instance should be removed.
Some entries may need additional context or verification:
- "gravel": Is this intended to be the English word, or is it used in French context?
- "ANSM": This appears to be an acronym. Could you provide its full form for reference?
- "Gojira": Is this a brand name or proper noun commonly used in French?
The other entries ("sémiographiques", "Tetris", "Marculfe") seem appropriate for inclusion.
To assist in verifying these entries, I can run a script to check their usage in French contexts. Would you like me to proceed with this verification?
This script will search for usage of each new word in the project, which might provide context for their inclusion in the French dictionary.
✅ Verification successful
Duplicate Entry Confirmed
The duplication of the word "romandisme" in
spelling.txt
has been confirmed. Please remove the duplicate entry to maintain the integrity of the dictionary.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check usage of new dictionary entries in French contexts # Function to search for word usage search_word() { echo "Searching for usage of: $1" rg -i -C 2 "\b$1\b" | grep -v "spelling.txt" } # Search for each new word search_word "sémiographiques" search_word "romandisme" search_word "gravel" search_word "ANSM" search_word "Gojira" search_word "Tetris" search_word "Marculfe"Length of output: 15306
See https://app.asana.com/0/1205948788428908/1208361466816659/f
Summary by CodeRabbit
New Features
Bug Fixes