Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Dictionary additions #10916

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[fr] Dictionary additions #10916

merged 1 commit into from
Oct 4, 2024

Conversation

LucieSteib
Copy link
Collaborator

@LucieSteib LucieSteib commented Oct 4, 2024

See https://app.asana.com/0/1205948788428908/1208361466816659/f

Summary by CodeRabbit

  • New Features

    • Expanded French vocabulary with new nouns, adjectives, and verbs in the part-of-speech dictionary.
    • Added new multiword expressions for improved text processing in French.
    • Enhanced spell checker with new words to be ignored, ensuring better accuracy.
  • Bug Fixes

    • Corrected formatting issues in various resource files to maintain consistency.

Copy link
Contributor

coderabbitai bot commented Oct 4, 2024

Walkthrough

The pull request introduces multiple updates to the French language module of LanguageTool, specifically enhancing the vocabulary by adding new entries to three files: added.txt, ignore.txt, and multiwords.txt. These updates include new terms, proper nouns, and multiword expressions, ensuring adherence to formatting standards and maintaining the overall structure of each file.

Changes

File Path Change Summary
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt Added several new entries for nouns, adjectives, and verbs, including "ANSM," "Gojira," and variations of "bilié."
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt Added new entries "VPE" and "ESMO" to the ignore list, ensuring proper formatting with a newline at the end.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt Introduced new multiword expressions like "body shaming" and "Docteur Strange," along with corrections for apostrophe usage.

Possibly related PRs

  • [fr] Adding words #10866: This PR adds new entries to the added.txt file in the French language module, which is directly related to the main PR that also modifies the same file by adding new terms and their grammatical annotations.
  • [fr] Dictionary additions #10876: This PR also modifies the added.txt file, introducing additional terms similar to those in the main PR, thus expanding the vocabulary in the French language module.
  • [fr] Dictionary additions new minister edition #10891: This PR adds new proper nouns to the multiwords.txt file, which is relevant as the main PR also contributes to the vocabulary expansion in the French language module, albeit in a different file.

Suggested reviewers

  • GillouLT

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 686bf29 and 70d79e2.

📒 Files selected for processing (4)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (1 hunks)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt (1 hunks)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1 hunks)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
🔥 Files not summarized due to errors (1)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt: Error: Server error: no LLM provider could handle the message
✅ Files skipped from review due to trivial changes (1)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt
🔇 Additional comments (13)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (7)

356-356: LGTM: New entry for "gravel" added correctly.

The entry follows the correct format and provides appropriate part-of-speech tags.


357-357: LGTM: New entry for "ANSM" added correctly.

The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be an acronym.


358-358: LGTM: New entry for "Gojira" added correctly.

The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be a proper noun.


359-359: LGTM: New entry for "Tetris" added correctly.

The entry follows the correct format and provides appropriate part-of-speech tags for the proper noun "Tetris".


360-360: LGTM: New entry for "Marculfe" added correctly.

The entry follows the correct format and provides appropriate part-of-speech tags for what appears to be a proper noun.


361-364: LGTM: New entries for "bilié" and its variations added correctly.

The entries follow the correct format and provide appropriate part-of-speech tags for all forms (masculine/feminine, singular/plural) of the adjective "bilié".


356-364: Summary: All new dictionary entries have been added correctly.

The changes to this file introduce 9 new entries to the French language dictionary. All entries follow the correct format (fullform;baseform;postags) and provide appropriate part-of-speech tags. The additions include nouns, proper nouns, and adjectives, expanding the vocabulary available for processing.

languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (5)

4810-4810: Entry for "Jean-Luc Bizien" looks good.

The new entry "Jean-Luc Bizien;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s), which is appropriate for a person's name.


4811-4811: Excellent addition of "body shaming".

The entry "body shaming;N m s" is correctly formatted and tagged. Its inclusion as a noun (N), masculine (m), and singular (s) is appropriate. This modern term enhances the lexicon's coverage of contemporary concepts.


4812-4812: Entry for "Daniel Arsand" is correct.

The new entry "Daniel Arsand;Z m s" is properly formatted and tagged as a proper noun (Z), masculine (m), and singular (s), which is appropriate for a person's name.


4813-4813: Excellent addition of "Petit Poucet".

The entry "Petit Poucet;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s). This addition enhances the lexicon's coverage of important cultural references in French folklore.


4814-4814: Great addition of "Docteur Strange".

The entry "Docteur Strange;Z m s" is correctly formatted and tagged as a proper noun (Z), masculine (m), and singular (s). The use of the French spelling "Docteur" is appropriate. This addition enhances the lexicon's coverage of modern pop culture references.

languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1)

34708-34712: ⚠️ Potential issue

Review of new dictionary entries

Thank you for adding these new entries to the French dictionary. I have a few observations and questions:

  1. The word "romandisme" is duplicated. This is likely an error and one instance should be removed.

  2. Some entries may need additional context or verification:

    • "gravel": Is this intended to be the English word, or is it used in French context?
    • "ANSM": This appears to be an acronym. Could you provide its full form for reference?
    • "Gojira": Is this a brand name or proper noun commonly used in French?
  3. The other entries ("sémiographiques", "Tetris", "Marculfe") seem appropriate for inclusion.

To assist in verifying these entries, I can run a script to check their usage in French contexts. Would you like me to proceed with this verification?

This script will search for usage of each new word in the project, which might provide context for their inclusion in the French dictionary.

✅ Verification successful

Duplicate Entry Confirmed

The duplication of the word "romandisme" in spelling.txt has been confirmed. Please remove the duplicate entry to maintain the integrity of the dictionary.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check usage of new dictionary entries in French contexts

# Function to search for word usage
search_word() {
    echo "Searching for usage of: $1"
    rg -i -C 2 "\b$1\b" | grep -v "spelling.txt"
}

# Search for each new word
search_word "sémiographiques"
search_word "romandisme"
search_word "gravel"
search_word "ANSM"
search_word "Gojira"
search_word "Tetris"
search_word "Marculfe"

Length of output: 15306

@LucieSteib LucieSteib merged commit 042be60 into master Oct 4, 2024
5 checks passed
@LucieSteib LucieSteib deleted the fr/dics branch October 4, 2024 15:32
@coderabbitai coderabbitai bot mentioned this pull request Dec 4, 2024
@coderabbitai coderabbitai bot mentioned this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant