[fr] Dictionary additions #10922
[fr] Dictionary additions #10922
Conversation
WalkthroughThe pull request introduces significant modifications to the French language module of LanguageTool, specifically updating the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (2)
Line range hint
1-4822: Overall, the new entries maintain consistency with the existing format.The new entries follow the established pattern of "expression;tag" and seem to be consistent in their structure. The majority of the new entries are proper nouns (tagged with Z), which is appropriate for names of people, places, and organizations.
However, there are a few points to note:
Some entries use lowercase letters for proper nouns, which might be inconsistent with French capitalization rules.
There are a few entries with unusual tags that might need verification:
- "pro forma;J e sp" (line 4453): The tag 'J' is typically used for adjectives, but "pro forma" can also function as an adverb.
- "boss des bécosses;N e s" (line 4456): This colloquial expression might benefit from additional tags or notes.
Some entries might benefit from additional or more specific tags:
- "casus belli;N m s" (line 4601): Consider adding the tag 'L' for Latin expressions.
Consider reviewing these specific entries and adjusting tags where appropriate to enhance the accuracy and usefulness of the multiword list.
Line range hint
1-4822: Consider adding a comment to explain the meaning of tags used.While the file structure is consistent, it would be helpful for maintainers and contributors to have a brief explanation of the tags used in the file. This could be added as a comment at the beginning of the file.
Consider adding a comment block at the beginning of the file explaining the meaning of the tags used. For example:
# Tag explanations: # Z: Proper noun # N: Common noun # J: Adjective # A: Adverb # V: Verb # P: Preposition # C: Conjunction # I: Interjection # T: Title # D: Determiner # m: Masculine # f: Feminine # s: Singular # p: Plural # e: Invariable (épicène) # sp: Singular and pluralThis will make the file more self-documenting and easier for others to understand and maintain.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
🔥 Files not summarized due to errors (1)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt: Error: Server error: no LLM provider could handle the message
🧰 Additional context used
🔇 Additional comments (15)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (12)
364-364: LGTM: Correct addition of feminine plural formThe addition of "biliées" as the feminine plural form of "bilié" is correct and consistent with French adjective inflection rules. The part-of-speech tag (J f p) is appropriate for a feminine plural adjective.
365-365: LGTM: Proper addition of a new proper nounThe entry for "Dindenault" is correctly formatted and tagged as a masculine singular proper noun (Z m s). This addition enhances the dictionary's coverage of proper names.
366-366: LGTM: Correct addition of mythological nameThe entry for "Phrixos" is properly formatted and tagged as a masculine singular proper noun (Z m s). This addition enhances the dictionary's coverage of mythological names.
367-367: LGTM: Proper addition of mythological nameThe entry for "Hellé" is correctly formatted and tagged as a feminine singular proper noun (Z f s). This addition complements the previous entry of Phrixos and enhances the dictionary's coverage of mythological names.
368-368: LGTM: Correct addition of proper nounThe entry for "Artaban" is properly formatted and tagged as a masculine singular proper noun (Z m s). This addition further expands the dictionary's coverage of proper names.
369-369: LGTM: Proper addition of proper nounThe entry for "Calprenède" is correctly formatted and tagged as a masculine singular proper noun (Z m s). This addition further enhances the dictionary's coverage of proper names, likely a surname or place name.
370-371: LGTM: Correct addition of dual-function wordThe entries for "mésostiche" are properly formatted and tagged as both a masculine singular noun (N m s) and a masculine singular adjective (J m s). This dual entry correctly captures the word's ability to function as both a noun and an adjective in French, enhancing the dictionary's accuracy for this literary term.
372-373: LGTM: Proper addition of gender-neutral adjectiveThe entries for "yogique" (singular) and "yogiques" (plural) are correctly formatted and tagged as gender-neutral adjectives (J e s and J e p, respectively). The use of 'e' (épicène) for gender correctly indicates that this adjective has the same form for both masculine and feminine. This addition enhances the dictionary's coverage of yoga-related terminology.
374-374: LGTM: Correct addition of proper nounThe entry for "Héraclée" is properly formatted and tagged as a feminine singular proper noun (Z f s). This addition enhances the dictionary's coverage of historical place names, likely referring to ancient Greek cities named Heraclea.
376-376: LGTM: Proper addition of place nameThe entry for "Pausilippe" is correctly formatted and tagged as a masculine singular proper noun (Z m s). This addition enhances the dictionary's coverage of place names, likely referring to Posillipo, a residential quarter of Naples, Italy.
364-376: Summary: Comprehensive and valuable additions to the French dictionaryThis update to the French dictionary includes a diverse range of new entries, covering proper nouns (mythological, historical, and geographical), specialized terms, and adjectives. The additions and modifications consistently follow the required format and significantly enhance the dictionary's coverage.
Key points:
- Proper nouns: Dindenault, Phrixos, Hellé, Artaban, Calprenède, Héraclée, Asculum, and Pausilippe
- Specialized terms: mésostiche (both as noun and adjective)
- Adjectives: yogique (with correct gender-neutral tagging)
- Modification: Extended forms for "bilié"
These changes will improve LanguageTool's ability to recognize and process a wider range of French terms, particularly in literary and historical contexts.
Note: The gender assignment for "Asculum" (feminine) has been flagged for verification, as it may potentially be incorrect.
Overall, this is a valuable update that enhances the French language module's capabilities.
375-375: Verify gender for "Asculum"The entry for "Asculum" is properly formatted and tagged as a proper noun (Z). However, while the addition of this ancient Roman city name enhances the dictionary, the feminine gender (f) assigned to it may be incorrect. In Latin, city names are typically neuter. Consider verifying if "Asculum" should be tagged as neuter or if there's a specific reason for it to be feminine in French usage.
To verify the gender of "Asculum" in French usage, you can run the following script:
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1)
4816-4822:⚠️ Potential issueThe last few entries seem to be inconsistently formatted.
The entries from line 4816 to 4822 have an unusual format, with a line number followed by a tilde (~) before the actual entry. This is inconsistent with the rest of the file and may cause issues when processing the data.
Remove the line numbers and tildes from these entries to maintain consistency with the rest of the file. For example:
-Matthieu Godbout;Z m s +Matthieu Godbout;Z m s -Jacques-Perry Salkow;Z m s +Jacques-Perry Salkow;Z m s -Francis Pacherie;Z m s +Francis Pacherie;Z m s -Louise de Vilmorin;Z f s +Louise de Vilmorin;Z f s -Jacques-Perry Salkow;Z m s +Jacques-Perry Salkow;Z m s -Frédéric Schmitter;Z m s +Frédéric Schmitter;Z m s -Gautier de Costes de La Calprenède;Z m s +Gautier de Costes de La Calprenède;Z m sAlso, note that "Jacques-Perry Salkow" is duplicated on lines 4817 and 4820. You may want to remove one of these duplicate entries.
Likely invalid or redundant comment.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (2)
34712-34722: Approved: Valuable additions to the French spelling dictionaryThe new entries enhance the French language module by including a diverse range of words:
- Proper nouns (e.g., Marculfe, Dindenault, Phrixos)
- Place names (e.g., Héraclée, Asculum)
- Adjectives (e.g., yogique)
- Specialized terms (e.g., mésostiche)
- Potential acronyms (e.g., ANSM)
These additions will improve LanguageTool's ability to recognize and validate a wider variety of French words, including names and specialized vocabulary. The inclusion of accented characters (e.g., in Héraclée, Hellé) is correct and important for French language support.
34712-34722: Summary: Positive enhancement to the French spelling dictionaryThese additions to the
spelling.txtfile significantly improve the French language module of LanguageTool. The new entries expand the dictionary's coverage of proper nouns, place names, adjectives, and specialized terms. This enhancement aligns perfectly with the PR objectives and will contribute to more accurate spell-checking and part-of-speech recognition for French text.Some notable improvements:
- Inclusion of historical and mythological names (e.g., Phrixos, Hellé, Artaban)
- Addition of geographical locations (e.g., Héraclée, Asculum)
- Expansion of specialized vocabulary (e.g., mésostiche, yogique)
These changes will result in fewer false positives for uncommon but valid words, enhancing the overall user experience of LanguageTool for French language users.
In the context of https://app.asana.com/0/1205948788428908/1208474717235976/f
Summary by CodeRabbit
New Features
Bug Fixes