[fr] Adding words #10866
[fr] Adding words #10866
Conversation
WalkthroughThe changes involve the addition of new entries across multiple resource files in the French language module of LanguageTool. These entries include terms, their variants, grammatical annotations, ignored words, and spelling corrections, covering a range of topics including geography, sports, and notable figures. The updates aim to enhance the linguistic resources available for grammar checking and language processing tasks. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt (1)
1400-1403: Duplicate Entry Found for "chokbar"The word "chokbar" appears twice in the ignore list, which may be an unintended duplication. Please review the file to determine if this duplication is necessary. If not, consider removing the duplicate entry to maintain the integrity of the ignore list.
- File:
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt- Occurrences: 2
Analysis chain
Review of Newly Added Ignored Words
The newly added words "streamons," "UPR," "chokbar," and "chokbar de bz" are correctly placed in alphabetical order and formatted consistently with the rest of the entries in the file. This ensures that the spell checker will appropriately ignore these terms during text analysis.
However, the static analysis tool flagged a potential duplication issue with the word "chokbar." This needs to be verified to ensure there is no unintended repetition that could affect the functionality.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify if the word "chokbar" is duplicated in the ignore list. # Test: Search for the word "chokbar" in the file. Expect: Only one occurrence. rg --type txt -c 'chokbar' languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txtLength of output: 129
Tools
LanguageTool
[duplication] ~1401-~1401: Possible typo: you repeated a word
Context: ...ames streamiez streamions streamons UPR chokbar chokbar de bz(ENGLISH_WORD_REPEAT_RULE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1 hunks)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
Additional context used
LanguageTool
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/ignore.txt
[duplication] ~1401-~1401: Possible typo: you repeated a word
Context: ...ames streamiez streamions streamons UPR chokbar chokbar de bz(ENGLISH_WORD_REPEAT_RULE)
Additional comments not posted (37)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/added.txt (28)
258-258: Entry Approved: "Amsterdam-Schiphol"The entry is correctly formatted and consistent with the guidelines for the resource file.
259-259: Entry Approved: "Anticor"The entry is correctly formatted and consistent with the guidelines for the resource file.
260-260: Entry Approved: "Mandelieu"The entry is correctly formatted and consistent with the guidelines for the resource file.
261-261: Entry Approved: "parasport"The entry is correctly formatted and consistent with the guidelines for the resource file.
262-262: Entry Approved: "parasports"The entry is correctly formatted and consistent with the guidelines for the resource file.
263-263: Entry Approved: "paratriathlon"The entry is correctly formatted and consistent with the guidelines for the resource file.
264-264: Entry Approved: "cécifoot"The entry is correctly formatted and consistent with the guidelines for the resource file.
265-265: Entry Approved: "Dalida"The entry is correctly formatted and consistent with the guidelines for the resource file.
266-266: Entry Approved: "Samain"The entry is correctly formatted and consistent with the guidelines for the resource file.
267-267: Entry Approved: "paralympiade"The entry is correctly formatted and consistent with the guidelines for the resource file.
268-268: Entry Approved: "paralympiades"The entry is correctly formatted and consistent with the guidelines for the resource file.
269-269: Entry Approved: "goalball"The entry is correctly formatted and consistent with the guidelines for the resource file.
270-270: Entry Approved: "parabadminton"The entry is correctly formatted and consistent with the guidelines for the resource file.
271-271: Entry Approved: "alumnus"The entry is correctly formatted and consistent with the guidelines for the resource file.
272-272: Entry Approved: "alumni"The entry is correctly formatted and consistent with the guidelines for the resource file.
273-273: Entry Approved: "Almodóvar"The entry is correctly formatted and consistent with the guidelines for the resource file.
274-274: Entry Approved: "Vésubie"The entry is correctly formatted and consistent with the guidelines for the resource file.
275-275: Entry Approved: "Saint-Gothard"The entry is correctly formatted and consistent with the guidelines for the resource file.
276-276: Entry Approved: "phéromonal"The entry is correctly formatted and consistent with the guidelines for the resource file.
277-277: Entry Approved: "aspectuel"The entry is correctly formatted and consistent with the guidelines for the resource file.
278-278: Entry Approved: "aspectuels"The entry is correctly formatted and consistent with the guidelines for the resource file.
279-279: Entry Approved: "aspectuelle"The entry is correctly formatted and consistent with the guidelines for the resource file.
280-280: Entry Approved: "aspectuelles"The entry is correctly formatted and consistent with the guidelines for the resource file.
281-281: Entry Approved: "solitarisme"The entry is correctly formatted and consistent with the guidelines for the resource file.
282-282: Entry Approved: "solitarismes"The entry is correctly formatted and consistent with the guidelines for the resource file.
283-283: Entry Approved: "vannetais"The entry is correctly formatted and consistent with the guidelines for the resource file.
284-284: Entry Approved: "vannetaise"The entry is correctly formatted and consistent with the guidelines for the resource file.
285-285: Entry Approved: "vannetaises"The entry is correctly formatted and consistent with the guidelines for the resource file.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (8)
4757-4757: New Entry: Eric Dupond-MorettiThe addition of "Eric Dupond-Moretti;Z m s" follows the existing format and correctly classifies this notable figure with the appropriate grammatical annotation (masculine singular). This entry should enhance the tool's recognition capabilities for this specific name.
4758-4758: New Entry: Pavel DourovThe entry "Pavel Dourov;Z m s" is formatted correctly and classified appropriately as masculine singular. This addition should help in accurately recognizing the name in French texts.
4759-4759: New Entry: Jean Le Rond d'AlembertThe entry for "Jean Le Rond d'Alembert;Z m s" is correctly formatted and classified. Including historical figures like d'Alembert can improve the contextual understanding of texts that reference historical and philosophical topics.
4760-4760: New Entry: aéroport de GillotThe addition of "aéroport de Gillot;Z m s" is formatted correctly. This entry will enhance the tool's ability to recognize and process this specific geographical location in French texts.
4761-4761: New Entry: Primoz Roglic"Primoz Roglic;Z m s" is added correctly with the appropriate grammatical annotation. Recognizing names of prominent sports figures like Primoz Roglic can be beneficial for sports-related content.
4762-4762: New Entry: La VueltaThe term "La Vuelta;Z f s" is added with the correct format and feminine singular classification. This entry is important for recognizing the name of this well-known cycling event in sports journalism and related content.
4763-4763: New Entry: Mostra de Venise"Mostra de Venise;Z f s" is formatted and classified correctly as feminine singular. This will help in the accurate recognition of the Venice Film Festival in French texts.
4764-4764: New Entry: La BérardeThe entry "La Bérarde;Z f s" is correctly formatted and classified as feminine singular. This geographical name addition will aid in the recognition of specific locations within French texts.
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/hunspell/spelling.txt (1)
34610-34637: Review of New Entries in the Spelling Resource FileThe new entries added to the
spelling.txtfile are as follows:
- Rivoli: A well-known street in Paris, correctly spelled.
- Amsterdam-Schiphol: Refers to the airport, correctly spelled.
- Anticor: An anti-corruption organization in France, correctly spelled.
- Mandelieu: A city in France, correctly spelled.
- Parasport, paratriathlon, cécifoot, goalball, parabadminton: Terms related to sports, particularly adaptive sports, correctly spelled.
- Dalida: A famous French-Italian singer, correctly spelled.
- Samain: An ancient Celtic festival, correctly spelled.
- Paralympiade, paralympiades: Terms related to the Paralympic Games, correctly spelled.
- Alumnus, alumni: Latin terms used in academic contexts, correctly spelled.
- Almodóvar: Refers to the Spanish film director Pedro Almodóvar, correctly spelled.
- Vésubie: A region in France, correctly spelled.
- Saint-Gothard: A mountain pass in the Alps, correctly spelled.
- Phéromonal, aspectuel, aspectuels, aspectuelle, aspectuelles: Adjectives, correctly spelled and agree with gender and number.
- Solitarisme, solitarismes: Noun referring to a philosophical or political stance, correctly spelled.
- Vannetais, vannetaise, vannetaises: Adjectives related to the Vannes area in Brittany, correctly spelled and agree with gender and number.
Overall, the additions are appropriate and correctly spelled, enhancing the French language module's capability to handle a wider range of vocabulary, including proper nouns and specialized terms.
As described in https://app.asana.com/0/1205948788428908/1208137952172456/f
Summary by CodeRabbit