Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Dictionary additions new minister edition #10891

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

LucieSteib
Copy link
Collaborator

@LucieSteib LucieSteib commented Sep 23, 2024

Adding new government members names.

Summary by CodeRabbit

  • New Features
    • Expanded the French language module with new proper nouns, enhancing the recognition and grammatical categorization of names within the LanguageTool.
    • Added multiple entries for individuals, improving the tool's accuracy in processing French text.

Copy link
Contributor

coderabbitai bot commented Sep 23, 2024

Walkthrough

The pull request introduces numerous new entries to the multiwords.txt file within the French language modules of LanguageTool. These entries consist of various proper nouns, mainly names of individuals, each accompanied by specific grammatical categories indicating gender and number. This update aims to enhance the coverage of proper nouns in the French language resource.

Changes

File Path Change Summary
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt Added multiple new proper noun entries with grammatical tags indicating gender and number.

Possibly related PRs

  • [fr] Adding words #10866: This PR adds new entries to the multiwords.txt file, similar to the main PR, which also introduces multiple proper nouns to the same file, enhancing the French language module.
  • [fr] Dictionary additions #10876: This PR also modifies the multiwords.txt file by adding new entries, including proper nouns, which aligns with the changes made in the main PR.

Suggested reviewers

  • GillouLT

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1)

4808-4808: Consider using hyphens for multi-part name

The entry for "Thani Mohamed Soilihi" uses spaces between name parts. For consistency with other multi-part names in the list and to ensure proper processing by the language tool, consider using hyphens instead.

Suggested change:

-Thani Mohamed Soilihi;Z m s
+Thani-Mohamed-Soilihi;Z m s

Please verify the correct formatting of this name according to official sources or the individual's preference.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d3011fd and fed6786.

Files selected for processing (1)
  • languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
Additional comments not posted (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1)

4772-4809: New government members added successfully

The new entries for government members have been added correctly to the multiwords list. Each entry follows the established format of "Name;grammatical category". The grammatical categories (Z f s for feminine singular and Z m s for masculine singular) are appropriately assigned based on the individuals' genders.

This addition aligns well with the PR objective of "Adding new government members names" and will help keep the language tool up-to-date with recent political developments.

However, I have a few suggestions for consistency and potential improvements:

  1. Consider alphabetizing the new entries to maintain consistency with the rest of the file and ease future maintenance.
  2. Double-check if any of these names should be hyphenated (e.g., "Jean-Noël Barrot" is correct, but there might be others).
  3. Verify if any of these individuals have compound last names that should be treated as a single unit (e.g., "Carrère-Gée" in "Marie-Claire Carrère-Gée").

These suggestions are not critical issues but could enhance the overall quality and consistency of the resource.

@LucieSteib LucieSteib merged commit f59f07c into master Sep 23, 2024
5 checks passed
@LucieSteib LucieSteib deleted the fr/government branch September 23, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant