-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fr] Dictionary additions new minister edition #10891
Conversation
WalkthroughThe pull request introduces numerous new entries to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1)
4808-4808
: Consider using hyphens for multi-part nameThe entry for "Thani Mohamed Soilihi" uses spaces between name parts. For consistency with other multi-part names in the list and to ensure proper processing by the language tool, consider using hyphens instead.
Suggested change:
-Thani Mohamed Soilihi;Z m s +Thani-Mohamed-Soilihi;Z m sPlease verify the correct formatting of this name according to official sources or the individual's preference.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1 hunks)
Additional comments not posted (1)
languagetool-language-modules/fr/src/main/resources/org/languagetool/resource/fr/multiwords.txt (1)
4772-4809
: New government members added successfullyThe new entries for government members have been added correctly to the multiwords list. Each entry follows the established format of "Name;grammatical category". The grammatical categories (Z f s for feminine singular and Z m s for masculine singular) are appropriately assigned based on the individuals' genders.
This addition aligns well with the PR objective of "Adding new government members names" and will help keep the language tool up-to-date with recent political developments.
However, I have a few suggestions for consistency and potential improvements:
- Consider alphabetizing the new entries to maintain consistency with the rest of the file and ease future maintenance.
- Double-check if any of these names should be hyphenated (e.g., "Jean-Noël Barrot" is correct, but there might be others).
- Verify if any of these individuals have compound last names that should be treated as a single unit (e.g., "Carrère-Gée" in "Marie-Claire Carrère-Gée").
These suggestions are not critical issues but could enhance the overall quality and consistency of the resource.
Adding new government members names.
Summary by CodeRabbit