Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some typos in keps #7266

Merged
merged 1 commit into from
Feb 8, 2018
Merged

fix some typos in keps #7266

merged 1 commit into from
Feb 8, 2018

Conversation

lijianfeng1993
Copy link
Contributor

@lijianfeng1993 lijianfeng1993 commented Feb 7, 2018

Allow edits from maintainers checkbox


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit eaabe2f

https://deploy-preview-7266--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2018
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@heckj
Copy link
Contributor

heckj commented Feb 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, lijianfeng1993, tengqm, xiangpengzhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 381eb97 into kubernetes:master Feb 8, 2018
@lijianfeng1993 lijianfeng1993 deleted the fix_typo_1 branch February 8, 2018 05:51
chenopis added a commit that referenced this pull request Feb 8, 2018
* 'master' of https://github.com/kubernetes/website: (379 commits)
  fix some typos in keps.md (#7266)
  Typo fix: recommend -> recommended (#7271)
  Update nodes.md (#7288)
  Fix patch image command in rolling update section (#7124)
  fix edx link (#7276)
  Update OWNERS_ALIASES for sig-openstack (#7280)
  Update ISSUE_TEMPLATE.md (#7284)
  Add Brad Topol to owner aliases. (#7246)
  modify the default update strategy of statefulset (#7270)
  Fix tags of workloads-related glossary (#7102)
  kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248)
  Remove CentOS guide that was already deprecated a while ago (#7242)
  fix typo (#7260)
  fix typo envrionment -> [environment] (#7262)
  fix a typo in kubernetes api (#7261)
  fix some typos (#7251)
  Update notes.md (#7259)
  Update notes.md (#7257)
  Fix file extension and remove not necessary sudo. (#7143)
  Update Azure Container Service to managed clusters (#6955)
  ...
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants