Fix some typos in docs/concepts/ #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 5e60598 https://deploy-preview-7251--kubernetes-io-master-staging.netlify.com |
tengqm
requested changes
Feb 6, 2018
| @@ -40,7 +40,7 @@ When creating a new API, consider whether to [aggregate your API with the Kubern | |||
| | Your API is [Declarative](#declarative-apis). | Your API does not fit the [Declarative](#declarative-apis) model. | | |||
| | You want your new types to be readable and writable using `kubectl`.| `kubectl` support is not required | | |||
| | You want to view your new types in a Kubernetes UI, such as dashboard, alongside built-in types. | Kubernetes UI support is not required. | | |||
| | You are developing a new API. | You already have program that serves your API and works well. | | |||
| | You are developing a new API. | You already have programed that serves your API and works well. | | |||
tengqm
requested changes
Feb 6, 2018
| @@ -216,7 +216,7 @@ form `http://foo.bar/volume` while a port based endpoint is of the form | |||
| `http://foo.bar:xxx`. | |||
|
|
|||
| In environments that use path based endpoints and Kubernetes is using the older | |||
| auto-detection logic a `BS API version autodetection failed.` error will be | |||
| auto-detection logic a `BS API version autodetection failed.` Error will be | |||
There was a problem hiding this comment.
sorry, this change is invalid as well. didn't notice it last time.
tengqm
approved these changes
Feb 6, 2018
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3, lijianfeng1993, xiangpengzhao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
chenopis
added a commit
that referenced
this pull request
Feb 8, 2018
* 'master' of https://github.com/kubernetes/website: (379 commits) fix some typos in keps.md (#7266) Typo fix: recommend -> recommended (#7271) Update nodes.md (#7288) Fix patch image command in rolling update section (#7124) fix edx link (#7276) Update OWNERS_ALIASES for sig-openstack (#7280) Update ISSUE_TEMPLATE.md (#7284) Add Brad Topol to owner aliases. (#7246) modify the default update strategy of statefulset (#7270) Fix tags of workloads-related glossary (#7102) kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248) Remove CentOS guide that was already deprecated a while ago (#7242) fix typo (#7260) fix typo envrionment -> [environment] (#7262) fix a typo in kubernetes api (#7261) fix some typos (#7251) Update notes.md (#7259) Update notes.md (#7257) Fix file extension and remove not necessary sudo. (#7143) Update Azure Container Service to managed clusters (#6955) ...
tehut
pushed a commit
to tehut/website
that referenced
this pull request
Feb 20, 2018
bsalamat
pushed a commit
to bsalamat/kubernetes.github.io
that referenced
this pull request
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is