Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo admisson -> [admission] #7259

Merged
merged 1 commit into from
Feb 7, 2018
Merged

fix typo admisson -> [admission] #7259

merged 1 commit into from
Feb 7, 2018

Conversation

Vylovthee
Copy link

@Vylovthee Vylovthee commented Feb 6, 2018 •
edited by k8s-reviewable
Loading

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0845657

https://deploy-preview-7259--kubernetes-io-master-staging.netlify.com

tengqm
tengqm approved these changes Feb 6, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2018
@Bradamant3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anniedy, Bradamant3, tengqm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit b7e1541 into kubernetes:master Feb 7, 2018
chenopis added a commit that referenced this pull request Feb 8, 2018
@chenopis
Merge branch 'master' of https://github.com/kubernetes/website into i18n
ebd3f64 
* 'master' of https://github.com/kubernetes/website: (379 commits)
  fix some typos in keps.md (#7266)
  Typo fix: recommend -> recommended (#7271)
  Update nodes.md (#7288)
  Fix patch image command in rolling update section (#7124)
  fix edx link (#7276)
  Update OWNERS_ALIASES for sig-openstack (#7280)
  Update ISSUE_TEMPLATE.md (#7284)
  Add Brad Topol to owner aliases. (#7246)
  modify the default update strategy of statefulset (#7270)
  Fix tags of workloads-related glossary (#7102)
  kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248)
  Remove CentOS guide that was already deprecated a while ago (#7242)
  fix typo (#7260)
  fix typo envrionment -> [environment] (#7262)
  fix a typo in kubernetes api (#7261)
  fix some typos (#7251)
  Update notes.md (#7259)
  Update notes.md (#7257)
  Fix file extension and remove not necessary sudo. (#7143)
  Update Azure Container Service to managed clusters (#6955)
  ...
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
@tehut
Update notes.md (kubernetes#7259)
a1bfcde
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@bsalamat
Update notes.md (kubernetes#7259)
c7c3ee6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm approved these changes

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vylovthee @k8sio-netlify-preview-bot @Bradamant3 @k8s-ci-robot @tengqm