Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Brad Topol to owner aliases. #7246

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Add Brad Topol to owner aliases. #7246

merged 2 commits into from
Feb 7, 2018

Conversation

bradtopol
Copy link
Contributor

@bradtopol bradtopol commented Feb 6, 2018 •
edited by k8s-reviewable
Loading

Signed-off-by: Brad Topol btopol@us.ibm.com
Add Brad Topol to owners alias per zacharysarah's request

NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>

Please delete this note before submitting the pull request.

Allow edits from maintainers checkbox

This change is Reviewable

@bradtopol
Add Brad Yopol to owner aliases.
159cbec 
Signed-off-by: Brad Topol <btopol@us.ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2018
@bradtopol bradtopol changed the title Add Brad Yopol to owner aliases. Add Brad Topol to owner aliases. Feb 6, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 6, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ebe85d3

https://deploy-preview-7246--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Contributor

/lgtm

/cc @zacharysarah
for approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2018
@heckj
Copy link
Contributor

heckj commented Feb 6, 2018

+1 - but I think we need to add Brad's handle to OWNERS under reviewers as well

@zacharysarah
Copy link
Contributor

@heckj Agreed. @bradtopol, please add an entry to OWNERS as well. 👍

@bradtopol
Copy link
Contributor Author

@heckj @zacharysarah Should be done now. Sorry for the delay. I flew RDU to San Jose stopping both in DTW and LAX on the way. So it was a long day. But I did get Shake Shack at LAX along the way! :-)

@heckj
Copy link
Contributor

heckj commented Feb 7, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol, heckj, xiangpengzhao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9f86266 into kubernetes:master Feb 7, 2018
@bradtopol bradtopol deleted the addbrad branch February 8, 2018 01:28
chenopis added a commit that referenced this pull request Feb 8, 2018
@chenopis
Merge branch 'master' of https://github.com/kubernetes/website into i18n
ebd3f64 
* 'master' of https://github.com/kubernetes/website: (379 commits)
  fix some typos in keps.md (#7266)
  Typo fix: recommend -> recommended (#7271)
  Update nodes.md (#7288)
  Fix patch image command in rolling update section (#7124)
  fix edx link (#7276)
  Update OWNERS_ALIASES for sig-openstack (#7280)
  Update ISSUE_TEMPLATE.md (#7284)
  Add Brad Topol to owner aliases. (#7246)
  modify the default update strategy of statefulset (#7270)
  Fix tags of workloads-related glossary (#7102)
  kubectl 1.9+ updated registry secret type and datakey: .dockercfg is now .dockerconfigjson, and datakey now wrapped in 'auths' element (#7248)
  Remove CentOS guide that was already deprecated a while ago (#7242)
  fix typo (#7260)
  fix typo envrionment -> [environment] (#7262)
  fix a typo in kubernetes api (#7261)
  fix some typos (#7251)
  Update notes.md (#7259)
  Update notes.md (#7257)
  Fix file extension and remove not necessary sudo. (#7143)
  Update Azure Container Service to managed clusters (#6955)
  ...
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
@bradtopol @tehut
Add Brad Topol to owner aliases. (kubernetes#7246)
9d97827 
* Add Brad Yopol to owner aliases.

Signed-off-by: Brad Topol <btopol@us.ibm.com>

* Added entry to OWNERS as well
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@bradtopol @bsalamat
Add Brad Topol to owner aliases. (kubernetes#7246)
b8f55ac 
* Add Brad Yopol to owner aliases.

Signed-off-by: Brad Topol <btopol@us.ibm.com>

* Added entry to OWNERS as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@zacharysarah zacharysarah

@xiangpengzhao xiangpengzhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bradtopol @k8sio-netlify-preview-bot @xiangpengzhao @heckj @zacharysarah @k8s-ci-robot