fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

revit13 · 2024-03-10T13:22:53Z

…ConfigMapAsVolume. Fixes #10548.

Description of your changes:
Part of #9714, #10400, #10483 and #10549

This PR supports the addition of missing optional fields to SecretAsVolume and ConfigMapAsVolume introduced in #10549. The fields were added to avoid failure when the secret or config map used as volume source are missing.

To be rebased and update go.mod after #10548.

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow · 2024-03-10T13:23:04Z

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com>

Signed-off-by: Revital Sur <eres@il.ibm.com>

Tomcli · 2024-03-13T16:50:11Z

/ok-to-test

Tomcli

/lgtm
/assign @chensun

Signed-off-by: Revital Sur <eres@il.ibm.com>

rimolive · 2024-03-24T13:50:08Z

/lgtm

Tomcli

/lgtm
@chensun could you review this PR? Thanks.

chensun

/lgtm

Tomcli · 2024-03-25T22:39:44Z

/test kubeflow-pipeline-backend-test

Tomcli · 2024-03-26T16:14:05Z

/retest

Signed-off-by: Revital Sur <eres@il.ibm.com>

Tomcli

/lgtm

Tomcli · 2024-03-27T22:25:39Z

Opened issue #10629 to track failing tests. Once upstream fixed the tests, we might need to rebase again.

rimolive · 2024-04-03T17:00:26Z

@revit13 Please rebase your PR to get the latest client code changes.

Signed-off-by: Revital Sur <eres@il.ibm.com>

google-oss-prow · 2024-04-03T20:10:18Z

@revit13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kubeflow-pipelines-samples-v2	`9c61a86`	link	false	`/test kubeflow-pipelines-samples-v2`
kfp-kubernetes-execution-tests	`9c61a86`	link	false	`/test kfp-kubernetes-execution-tests`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Tomcli

/lgtm

google-oss-prow · 2024-04-03T20:20:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chensun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubeflow#10550) * fix(Backend + SDK): Add missing optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after rebase. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after rebase. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after merge. Signed-off-by: Revital Sur <eres@il.ibm.com> * Updates after merge with master branch. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>

cherry-pick from kubeflow#10550

kubeflow#10550) * fix(Backend + SDK): Add missing optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after rebase. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after rebase. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update after merge. Signed-off-by: Revital Sur <eres@il.ibm.com> * Updates after merge with master branch. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 marked this pull request as draft March 10, 2024 13:23

google-oss-prow bot added do-not-merge/work-in-progress size/L needs-ok-to-test labels Mar 10, 2024

google-oss-prow bot requested review from chensun and Tomcli March 10, 2024 13:23

revit13 force-pushed the patch5 branch from b8007b2 to d4a3c02 Compare March 11, 2024 12:04

revit13 added 2 commits March 13, 2024 06:19

fix(Backend + SDK): Add missing optional field to SecretAsVolume and …

61c3ba3

…ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com>

Update after rebase.

aa368db

Signed-off-by: Revital Sur <eres@il.ibm.com>

revit13 force-pushed the patch5 branch from d4a3c02 to aa368db Compare March 13, 2024 11:41

revit13 marked this pull request as ready for review March 13, 2024 11:41

google-oss-prow bot removed the do-not-merge/work-in-progress label Mar 13, 2024

google-oss-prow bot requested review from connor-mccarthy and zijianjoy March 13, 2024 11:41

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Mar 13, 2024

Tomcli reviewed Mar 14, 2024

View reviewed changes

google-oss-prow bot assigned chensun and Tomcli Mar 14, 2024

google-oss-prow bot added the lgtm label Mar 14, 2024

Update after rebase.

e0a7d78

Signed-off-by: Revital Sur <eres@il.ibm.com>

google-oss-prow bot removed the lgtm label Mar 24, 2024

google-oss-prow bot assigned rimolive Mar 24, 2024

google-oss-prow bot added the lgtm label Mar 24, 2024

Tomcli approved these changes Mar 25, 2024

View reviewed changes

chensun approved these changes Mar 25, 2024

View reviewed changes

google-oss-prow bot added the approved label Mar 25, 2024

revit13 added 2 commits March 26, 2024 22:01

Merge branch 'master' into patch5

f84c683

Signed-off-by: Revital Sur <eres@il.ibm.com>

Update after merge.

535d1d6

Signed-off-by: Revital Sur <eres@il.ibm.com>

google-oss-prow bot removed the lgtm label Mar 27, 2024

Tomcli reviewed Mar 27, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Mar 27, 2024

revit13 added 2 commits April 3, 2024 14:03

Merge branch 'master' into patch5

3ec23c3

Signed-off-by: Revital Sur <eres@il.ibm.com>

Updates after merge with master branch.

9c61a86

Signed-off-by: Revital Sur <eres@il.ibm.com>

google-oss-prow bot removed the lgtm label Apr 3, 2024

Tomcli approved these changes Apr 3, 2024

View reviewed changes

google-oss-prow bot added the lgtm label Apr 3, 2024

google-oss-prow bot merged commit a78dc77 into kubeflow:master Apr 3, 2024
12 of 14 checks passed

openshift-merge-bot bot added a commit to opendatahub-io/data-science-pipelines that referenced this pull request Apr 16, 2024

Merge pull request #33 from rimolive/rmartine

3efe0f0

cherry-pick from kubeflow#10550

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

revit13 commented Mar 10, 2024 •

edited

Loading

google-oss-prow bot commented Mar 10, 2024

Tomcli commented Mar 13, 2024

Tomcli left a comment

rimolive commented Mar 24, 2024

Tomcli left a comment

chensun left a comment

Tomcli commented Mar 25, 2024

Tomcli commented Mar 26, 2024

Tomcli left a comment

Tomcli commented Mar 27, 2024

rimolive commented Apr 3, 2024

google-oss-prow bot commented Apr 3, 2024 •

edited

Loading

Tomcli left a comment

google-oss-prow bot commented Apr 3, 2024

fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

fix(Backend + SDK): Add missing optional field to SecretAsVolume and … #10550

Conversation

revit13 commented Mar 10, 2024 • edited Loading

google-oss-prow bot commented Mar 10, 2024

Tomcli commented Mar 13, 2024

Tomcli left a comment

Choose a reason for hiding this comment

rimolive commented Mar 24, 2024

Tomcli left a comment

Choose a reason for hiding this comment

chensun left a comment

Choose a reason for hiding this comment

Tomcli commented Mar 25, 2024

Tomcli commented Mar 26, 2024

Tomcli left a comment

Choose a reason for hiding this comment

Tomcli commented Mar 27, 2024

rimolive commented Apr 3, 2024

google-oss-prow bot commented Apr 3, 2024 • edited Loading

Tomcli left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Apr 3, 2024

revit13 commented Mar 10, 2024 •

edited

Loading

google-oss-prow bot commented Apr 3, 2024 •

edited

Loading