Fixes after testing.

Signed-off-by: Revital Sur <eres@il.ibm.com>
kubeflow · Mar 11, 2024 · b8007b2 · b8007b2
1 parent 57b539e
commit b8007b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/backend/src/v2/driver/driver_test.go b/backend/src/v2/driver/driver_test.go
@@ -530,7 +530,7 @@ func Test_extendPodSpecPatch_Secret(t *testing.T) {
 					{
 						Name: "secret1",
 						VolumeSource: k8score.VolumeSource{
-							Secret: &k8score.SecretVolumeSource{SecretName: "secret1"},
+							Secret: &k8score.SecretVolumeSource{SecretName: "secret1", Optional:  &[]bool{false}[0],},
 						},
 					},
 				},
@@ -727,7 +727,8 @@ func Test_extendPodSpecPatch_ConfigMap(t *testing.T) {
 						Name: "cm1",
 						VolumeSource: k8score.VolumeSource{
 							ConfigMap: &k8score.ConfigMapVolumeSource{
-								LocalObjectReference: k8score.LocalObjectReference{Name: "cm1"}},
+								LocalObjectReference: k8score.LocalObjectReference{Name: "cm1"},
+								Optional:             &[]bool{false}[0],},
 						},
 					},
 				},

diff --git a/kubernetes_platform/python/README.md b/kubernetes_platform/python/README.md
@@ -58,7 +58,7 @@ def pipeline():
                                     mount_path='/mnt/my_vol')
 ```
 
-### Secret: As mounted volume with optional field
+### Secret: As optional source for a mounted volume
 ```python
 from kfp import dsl
 from kfp import kubernetes
@@ -113,7 +113,7 @@ def pipeline():
                                        mount_path='/mnt/my_vol')
 ```
 
-### ConfigMap: As mounted volume with optional field
+### ConfigMap: As optional source for a mounted volume
 ```python
 from kfp import dsl
 from kfp import kubernetes