Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 #10549

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

revit13
Copy link
Contributor

@revit13 revit13 commented Mar 10, 2024

Description of your changes:
Part of #10400 and #10548

This PR adds missing optional field to SecretAsVolume and ConfigMapAsVolume to avoid a failure when the secret or config map used as volume source are missing.

Checklist:

…nfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>
Copy link

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@revit13 revit13 changed the title fix(kubernetes_platform): Add optional field to SecretAsVolum… fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 Mar 10, 2024
@revit13 revit13 force-pushed the patch4 branch 2 times, most recently from eb2e813 to 64366d7 Compare March 10, 2024 13:08
@revit13 revit13 changed the title fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 fix(sdk): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 Mar 10, 2024
@revit13 revit13 changed the title fix(sdk): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 Mar 10, 2024
Signed-off-by: Revital Sur <eres@il.ibm.com>
Copy link
Member

@Tomcli Tomcli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@rimolive
Copy link
Member

/test kfp-kubernetes-execution-tests

@rimolive
Copy link
Member

Last attempt

/test kfp-kubernetes-execution-tests

Copy link

@revit13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kfp-kubernetes-execution-tests aaa5070 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Tomcli
Copy link
Member

Tomcli commented Mar 12, 2024

@rimolive You don't need to trigger the test if it's not required. That also could help lower the workload on the e2e pipelines.

@Tomcli
Copy link
Member

Tomcli commented Mar 12, 2024

/assign @chensun

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9253c7a into kubeflow:master Mar 13, 2024
9 of 10 checks passed
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 27, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this pull request Mar 28, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this pull request Sep 23, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants