-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Fixes #10548 #10549
Conversation
…nfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com>
Hi @revit13. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eb2e813
to
64366d7
Compare
Signed-off-by: Revital Sur <eres@il.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
/test kfp-kubernetes-execution-tests |
Last attempt /test kfp-kubernetes-execution-tests |
@revit13: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rimolive You don't need to trigger the test if it's not required. That also could help lower the workload on the e2e pipelines. |
/assign @chensun |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549) * fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update comment. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549) * fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update comment. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549) * fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update comment. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549) * fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume. Signed-off-by: Revital Sur <eres@il.ibm.com> * Update comment. Signed-off-by: Revital Sur <eres@il.ibm.com> --------- Signed-off-by: Revital Sur <eres@il.ibm.com>
Description of your changes:
Part of #10400 and #10548
This PR adds missing optional field to SecretAsVolume and ConfigMapAsVolume to avoid a failure when the secret or config map used as volume source are missing.
Checklist: