Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk] Missing optional parameter to v2 use_config_map_as_volume and use_secret_as_volume #10548

Closed
revit13 opened this issue Mar 10, 2024 · 0 comments · Fixed by #10550
Closed

Comments

@revit13
Copy link
Contributor

revit13 commented Mar 10, 2024

In kfp v1 the config map or secret can be marked as optional when used as a volume source, as shown in the example below.

This capability is missing in the recent added use_config_map_as_volume and use_secret_as_volume v2 sdk functions. (#10400, #10483)

vol = k8s_client.V1Volume(
        name='dummy',
        config_map=k8s_client.V1ConfigMapVolumeSource(name='name', optional=True),
    )
    component.add_pvolumes({mountPoint: vol})


vol = k8s_client.V1Volume(
        name='dummy',
        secret=k8s_client.V1SecretVolumeSource(secret_name='name', optional=False),
    )
    component.add_pvolumes({mountPoint: vol})

What is the use case or pain point?

Making the secret or config map an optional resource allows the KFP component to function without failing even if those resources are not present.

revit13 added a commit to revit13/pipelines that referenced this issue Mar 10, 2024
…nfigMapAsVolume. Fixes kubeflow#10548.

Signed-off-by: Revital Sur <eres@il.ibm.com>
revit13 added a commit to revit13/pipelines that referenced this issue Mar 10, 2024
…ConfigMapAsVolume. Fixes kubeflow#10548.

Signed-off-by: Revital Sur <eres@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this issue Mar 27, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
rimolive pushed a commit to rimolive/data-science-pipelines that referenced this issue Mar 28, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
petethegreat pushed a commit to petethegreat/pipelines that referenced this issue Mar 29, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
VaniHaripriya pushed a commit to VaniHaripriya/data-science-pipelines that referenced this issue Sep 23, 2024
…nfigMapAsVolume. Fixes kubeflow#10548 (kubeflow#10549)

* fix(kubernetes_platform): Add optional field to SecretAsVolume and ConfigMapAsVolume.

Signed-off-by: Revital Sur <eres@il.ibm.com>

* Update comment.

Signed-off-by: Revital Sur <eres@il.ibm.com>

---------

Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant