Push multi-arch images

[ddelange]

Motivation

Upstream image does not build 32bit arm images ref #79 (comment), so disabled them and re-opening the PR ref #76

Modifications

one commit 74e6eda

Related PRs

• Push multi-arch images  #80
• Enable multi-platform build modelmesh-minio-examples#3
• Push multi-arch images modelmesh-runtime-adapter#38
• Push multi-arch images modelmesh-serving#314
• Push multi-arch images rest-proxy#24

[ckadner]

@ddelange -- the .github/workflows/pull-request-validation.yml workflow needs to be changed as well so that the multi-arch build gets tested on PRs including this one :-)

It might be better to consolidate the two workflow files into one file and work with conditions to not push images to DockerHub for PR validation (only on push to main or pushing tags)

[ddelange]

SGTM, I'll take some time early next week to:

• add pull_request trigger
• add conditionals so there's no pushing on PR
• remove the other workflow yaml

would you like me to update the other PRs in the same fashion?

[ckadner]

would you like me to update the other PRs in the same fashion?

Thanks @ddelange -- yup, we should consolidate the workflow files on all the modelmesh repos:

• modelmesh (Push multi-arch images  #80)
• modelmesh-runtime-adapter (Push multi-arch images modelmesh-runtime-adapter#38)
• modelmesh-serving (Push multi-arch images modelmesh-serving#314)
• rest-proxy (Push multi-arch images rest-proxy#24)

Unfortunately they all have somewhat different setups currently with respect to the Dockerfile (Dockerfile.develop), and the related docker build instructions in the README files, the build commands in the Makefile and sometimes in build scripts, on top of the GitHub workflows. So there is a bit of complexity to figure out that might take up more time than you had bargained for :-)

[ddelange]

@ckadner Ci is green:) maven didn't like s390x arch so I removed it

[ckadner]

Looks good. Just two minor questions :-)

[ckadner]

Great. Thanks @ddelange -- let's remove the the commented out code pieces and the extra IMAGE_ID/IMAGE_NAME changes

[ckadner]

/lgtm

Thanks @ddelange

[njhill]

Thanks a lot for all your work on this @ddelange @ckadner!

[kserve-oss-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, ddelange, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njhill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[njhill]

/lgtm