Push multi-arch docker image #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ddelange The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9 tasks
ddelange
added a commit
to ddelange/rest-proxy
that referenced
this pull request
Jan 2, 2023
cherry-picked from kserve/modelmesh#76 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
njhill
pushed a commit
to kserve/rest-proxy
that referenced
this pull request
Jan 8, 2023
cherry-picked from kserve/modelmesh#76 Signed-off-by: ddelange <14880945+ddelange@users.noreply.github.com>
njhill
approved these changes
Jan 8, 2023
|
/lgtm |
njhill
added a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit d9892e3. Signed-off-by: Nick Hill <nickhill@us.ibm.com>
kserve-oss-bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
This reverts commit d9892e3. These changes actually broke our main image build. Unfortunately the actions that run on the PR don't actually build the image. @ckadner is addressing that and then we can reopen this if needed post 0.10 release. @ddelange it probably only makes sense anyhow if we do this for all the modelmesh images i.e. also including `modelmesh-serving` and `modelmesh-runtime-adapter` Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Feature parity with kserve and knative ref kserve/kserve#2550 (comment)
Fixes kserve/kserve#2612
Modifications
testjob on PRpushResult
Can run on e.g. AWS graviton family instances (arm64)