Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Push multi-arch docker image (#76)" #79

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

njhill
Copy link
Member

@njhill njhill commented Jan 10, 2023

This reverts commit d9892e3.

These changes actually broke our main image build. Unfortunately the actions that run on the PR don't actually build the image. @ckadner is addressing that and then we can reopen this if needed post 0.10 release.

@ddelange it probably only makes sense anyhow if we do this for all the modelmesh images i.e. also including modelmesh-serving and modelmesh-runtime-adapter

This reverts commit d9892e3.

Signed-off-by: Nick Hill <nickhill@us.ibm.com>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, njhill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kserve-oss-bot kserve-oss-bot merged commit 38c1385 into main Jan 10, 2023
@njhill njhill deleted the revert-multi-arch branch January 10, 2023 20:19
@ddelange
Copy link
Contributor

ah damn, looks like there's an upstream image that does not build for arm64, sorry about that

@ddelange
Copy link
Contributor

ddelange commented Jan 16, 2023

this is weird, should be available according to the manifest

$ dockersize registry.access.redhat.com/ubi8/ubi-minimal:8.6
linux/amd64    37.82M
linux/arm64    36.16M
linux/ppc64le  42.24M
linux/s390x    36.12M

let me try to build the branch on my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants