Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-platform build #92

Merged
merged 6 commits into from
May 13, 2023
Merged

Fix multi-platform build #92

merged 6 commits into from
May 13, 2023

Conversation

ckadner
Copy link
Member

@ckadner ckadner commented May 11, 2023 •
edited
Loading

Motivation

Fix multi-platform build introduced in PR #80

Modifications

Don't use "default" for ARGs TARGETOS and TARGETARCH in Dockerfile.

Result

Images of kserve/modelmesh for platforms linux/amd64, linux/arm64, linux/ppc64le.

Related PRs

@ckadner
Don't use "default" for ARGs TARGETOS and TARGETARCH
c3e893a 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner removed the request for review from rafvasq May 11, 2023 01:53
@ckadner ckadner marked this pull request as draft May 11, 2023 01:53
@ckadner ckadner self-assigned this May 11, 2023
@ckadner ckadner added this to the v0.11.0 milestone May 11, 2023
@ckadner ckadner removed the request for review from tjohnson31415 May 11, 2023 01:54
ckadner added 4 commits May 11, 2023 16:11
@ckadner
Test installed packages
6b97451 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Update README.md
ae0e85b 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
Harmonize workflow YAML
523a8d6 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner
.dockerignore
6df330c 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner marked this pull request as ready for review May 12, 2023 08:30
@ckadner ckadner requested a review from tjohnson31415 May 12, 2023 08:30
@ckadner ckadner changed the title [WIP] Fix multi-platform build Fix multi-platform build May 12, 2023
@ckadner
New lines
94afcf8 
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
@ckadner ckadner assigned tjohnson31415 and unassigned ckadner May 12, 2023
@ckadner ckadner mentioned this pull request May 12, 2023
Merged
@ckadner
Copy link
Member Author

ckadner commented May 12, 2023

Goes with PR kserve/modelmesh-serving#371

tjohnson31415
tjohnson31415 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@tjohnson31415 tjohnson31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmonizes with the other multi-arch builds.
LGTM

@kserve-oss-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, tjohnson31415

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ckadner ckadner merged commit dde5ca8 into kserve:main May 13, 2023
@ckadner ckadner linked an issue Jun 2, 2023 that may be closed by this pull request
Quick start not working for Mac M1 laptops kserve/modelmesh-serving#162
Closed
@ckadner ckadner removed a link to an issue Jun 2, 2023
Quick start not working for Mac M1 laptops kserve/modelmesh-serving#162
Closed
@ckadner ckadner linked an issue Jun 2, 2023 that may be closed by this pull request
Quick start not working for Mac M1 laptops kserve/modelmesh-serving#162
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjohnson31415 tjohnson31415 tjohnson31415 approved these changes

Assignees

@tjohnson31415 tjohnson31415

Labels
approved
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Quick start not working for Mac M1 laptops
3 participants
@ckadner @kserve-oss-bot @tjohnson31415