Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected items foreground color on dark theme #47

Merged
merged 1 commit into from
Jan 10, 2021

Conversation

uninhm
Copy link
Contributor

@uninhm uninhm commented Dec 29, 2020

No description provided.

@uninhm uninhm mentioned this pull request Dec 29, 2020
@kraxarn
Copy link
Owner

kraxarn commented Dec 31, 2020

Thanks, noticed this as well, but didn't get the time to fix it.

I did notice the settings don't quite work though. Selecting an item makes the icon disappear (same happens with the play icon in the tracks list):
image

And the text in the list uses the normal text color by default, unless a dropdown item is selected, which looks odd. Maybe better to just always use the default text color in this case?
image
Notice how the "Application" text is a bit brighter now, probably using #ffffff instead of #f5f5f5:
image

Also, noticed that the dropdowns don't work either:
image

@uninhm
Copy link
Contributor Author

uninhm commented Jan 5, 2021

@kraxarn test that commit please

@uninhm
Copy link
Contributor Author

uninhm commented Jan 5, 2021

And, what do you think about this:
$highlight-color: #0d6954;

@kraxarn
Copy link
Owner

kraxarn commented Jan 6, 2021

Only the issue of items in the dropdowns disappearing when being hovered over seems to be fixed, the other issues are still present.

The colors are primarily meant to be the same as the ones in the official client, or at least as seen in the web player as I currently don't have the actual client installed. I think most of the colors are fine for now, but they may be changed once the new theme is fully implemented and everything works as expected.

@uninhm
Copy link
Contributor Author

uninhm commented Jan 6, 2021

Only the issue of items in the dropdowns disappearing when being hovered over seems to be fixed, the other issues are still present.

In my case all issues are solved...

#itworksonmymachine

@uninhm
Copy link
Contributor Author

uninhm commented Jan 6, 2021

image
image

The evidence

@kraxarn
Copy link
Owner

kraxarn commented Jan 6, 2021

Probably safe to merge this then and i can try to troubleshoot the remaining issues later 😊

@kraxarn kraxarn merged commit f10ea1e into kraxarn:master Jan 10, 2021
@kraxarn
Copy link
Owner

kraxarn commented Jan 10, 2021

Merging this as-is for now, and leave the new dark theme behind developer mode until the other issues are resolved.

kraxarn pushed a commit that referenced this pull request Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants