Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme bug #42

Closed
uninhm opened this issue Dec 23, 2020 · 10 comments
Closed

Dark theme bug #42

uninhm opened this issue Dec 23, 2020 · 10 comments

Comments

@uninhm
Copy link
Contributor

uninhm commented Dec 23, 2020

This commit has the following bug:

image

@uninhm uninhm changed the title Dark the bug Dark theme bug Dec 23, 2020
@kraxarn
Copy link
Owner

kraxarn commented Dec 23, 2020

It's in the master branch and untested :p Should be fixed in 7034483 though.

@uninhm
Copy link
Contributor Author

uninhm commented Dec 23, 2020

It's in the master branch and untested :p

So it should be an 'untested' branch for that. I though 'master' branch was with working code :P

I can open an issue for that if you want 😝

@uninhm
Copy link
Contributor Author

uninhm commented Dec 23, 2020

Should be fixed in 7034483 though.

It is missing menus, buttons mouse-over-highlight, checkbuttons, line-edits, comboboxes...

@uninhm
Copy link
Contributor Author

uninhm commented Dec 23, 2020

You can set an 'stable' branch as default:

https://github.com/uninhm/spotify-qt

@kraxarn
Copy link
Owner

kraxarn commented Dec 23, 2020

I'll test it some more when I get the time to.
I know how branches work, it's just how it's set up currently as breaking changes aren't very common :p

@uninhm
Copy link
Contributor Author

uninhm commented Dec 29, 2020

@kraxarn tracks info is unreadable when selected

@uninhm
Copy link
Contributor Author

uninhm commented Dec 29, 2020

Fixed, see #47

@uninhm
Copy link
Contributor Author

uninhm commented Dec 29, 2020

I think that's the last bug, so the PR closes this issue.

@uninhm
Copy link
Contributor Author

uninhm commented May 22, 2021

Whaaaat, why isn't this closed? Are there still bugs about this?

@kraxarn
Copy link
Owner

kraxarn commented May 23, 2021

The only bug I'm currently aware of is that system icons doesn't work well with the custom dark theme. Workaround being that built-in icons are automatically enabled when using the custom dark theme.
I mostly forgot about this issue, but I guess it's safe to close now ☺️

@kraxarn kraxarn closed this as completed May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants