Fix dark theme selection color (#47)

kraxarn · Feb 7, 2021 · 5876b47 · 5876b47
1 parent edb81d1
commit 5876b47
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/res/style/dark.qss b/res/style/dark.qss
@@ -1,6 +1,10 @@
 QWidget {
+  color: #f5f5f5;
   selection-background-color: #282828;
-  color: #f5f5f5; }
+  selection-color: #f5f5f5; }
+  QWidget::item::selected {
+    background-color: #282828;
+    color: #f5f5f5; }
 
 QScrollBar::handle {
   background-color: #4d4d4d; }

diff --git a/res/style/dark.scss b/res/style/dark.scss
@@ -31,6 +31,8 @@ $input-secondary-background-color: #b2b2b2;
 $foreground-color: #f5f5f5;
 // Color of selected items etc.
 $highlight-color: $secondary-background-color;
+// Font color of selected items etc.
+$highlight-foreground-color: $foreground-color;
 // Main Spotify green color
 $theme-color: #1db954;
 // Color for disabled text etc.
@@ -50,8 +52,15 @@ $slider-handle-color: #ffffff;
 }
 
 QWidget {
-	selection-background-color: $highlight-color;
 	color: $foreground-color;
+
+	// Both selection[...] and &::item::selected{...} are needed for different OS
+	selection-background-color: $highlight-color;
+	selection-color: $highlight-foreground-color;
+	&::item::selected {
+		background-color: $highlight-color;
+		color: $highlight-foreground-color;
+	}
 }
 
 QScrollBar {